maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   [M5] [Announce] Yappari - New maintainership and new features! (https://talk.maemo.org/showthread.php?t=94465)

Faso_II 2015-03-06 08:39

Re: [Announce] Yappari - New maintainership and new features!
 
My Yappari is working fine...
One thing: now people that I don't know in new groups are displayed with their telephone number, while in the past I could see their nickname.
Is this a common issue?

ceene 2015-03-06 08:49

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by Faso_II (Post 1463208)
My Yappari is working fine...
One thing: now people that I don't know in new groups are displayed with their telephone number, while in the past I could see their nickname.
Is this a common issue?

It seems to be, but no one has ever sent me a log to help me debug this issue...

guidofasano 2015-03-06 15:09

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463210)
It seems to be, but no one has ever sent me a log to help me debug this issue...

Yo aun presento el mismo problema, que al conectarse se cierra automaticamente yappari. ayer te volvi a enviar el nuevo registro de error por correo, espero puedas resolver, gracias por tu tiempo.

ceene 2015-03-06 16:09

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by guidofasano (Post 1463253)
Yo aun presento el mismo problema, que al conectarse se cierra automaticamente yappari. ayer te volvi a enviar el nuevo registro de error por correo, espero puedas resolver, gracias por tu tiempo.

Muchas gracias. Con suerte, si el trabajo me lo permite, durante el fin de semana podré avanzar con tu problema.

keerty 2015-03-06 18:13

Re: [Announce] Yappari - New maintainership and new features!
 
Thanks to all who have been supporting the application for so long! Its a big help !
my yappari is unable to register for the last 10 hours, its the same issue faces earlier in january. any fixes anyone is aware of ?

NerdKnight 2015-03-07 01:13

Re: [Announce] Yappari - New maintainership and new features!
 
1 Attachment(s)
I've compiled Yappari 2.0.8 with debugging symbols and this is the backtrace when it crash with segfault:
Code:

#0  0x414f03d2 in QIODevice::isOpen() const () from /usr/lib/libQtCore.so.4
#1  0x00071908 in BinTreeNodeReader::getOneToplevelStream (this=0x8400e8)
    at Whatsapp/bintreenodereader.cpp:58
#2  0x000719cc in BinTreeNodeReader::nextTree (this=0x8400e8, node=...)
    at Whatsapp/bintreenodereader.cpp:142
#3  0x0004ec50 in Connection::read (this=0xea4060)
    at Whatsapp/connection.cpp:142
#4  0x00076e54 in Client::read (this=0x3f82e0) at client.cpp:1132
#5  0x0013d760 in Client::qt_metacall (this=0x3f82e0,
    _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0xbe880f80)
    at moc_client.cpp:193

I made some validations to the code, attached a patch, I will continue debugging and let you know if I find something else.

coderus 2015-03-07 01:49

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by NerdKnight (Post 1463301)
I've compiled Yappari 2.0.8 with debugging symbols and this is the backtrace when it crash with segfault:
Code:

#0  0x414f03d2 in QIODevice::isOpen() const () from /usr/lib/libQtCore.so.4
#1  0x00071908 in BinTreeNodeReader::getOneToplevelStream (this=0x8400e8)
    at Whatsapp/bintreenodereader.cpp:58
#2  0x000719cc in BinTreeNodeReader::nextTree (this=0x8400e8, node=...)
    at Whatsapp/bintreenodereader.cpp:142
#3  0x0004ec50 in Connection::read (this=0xea4060)
    at Whatsapp/connection.cpp:142
#4  0x00076e54 in Client::read (this=0x3f82e0) at client.cpp:1132
#5  0x0013d760 in Client::qt_metacall (this=0x3f82e0,
    _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0xbe880f80)
    at moc_client.cpp:193

I made some validations to the code, attached a patch, I will continue debugging and let you know if I find something else.

This is not socket isOpen, this is QBuffer one here: https://github.com/agamez/yappari/bl...reader.cpp#L58

ceene 2015-03-07 11:29

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by coderus (Post 1463302)
This is not socket isOpen, this is QBuffer one here: https://github.com/agamez/yappari/bl...reader.cpp#L58

How is it possible for isOpen to segfault? I'm struggling to understand the reason.

freemangordon 2015-03-07 13:57

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463318)
How is it possible for isOpen to segfault? I'm struggling to understand the reason.

If the object you're calling isOpen on (i.e. this pointer) is invalid ;)

NerdKnight 2015-03-07 17:19

Re: [Announce] Yappari - New maintainership and new features!
 
Maybe closing the QBuffer at the end of nextTree method instead at the beginning could do the trick, I'll test it.
Code:

diff --git a/src/yappari-application/Whatsapp/bintreenodereader.cpp b/src/yappari-application/Whatsapp/bintreenodereader.cpp
index 6d32774..59b42c5 100644
--- a/src/yappari-application/Whatsapp/bintreenodereader.cpp
+++ b/src/yappari-application/Whatsapp/bintreenodereader.cpp
@@ -146,6 +146,9 @@ bool BinTreeNodeReader::nextTree(ProtocolTreeNode& node)
    node.setSize(getOneToplevelStreamSize());
 
    result = nextTreeInternal(node);
+    if (decodedStream.isOpen()) {
+        decodedStream.close();
+    }
    Utilities::logData("INCOMING:\n" + node.toString());
    return result;
 }


ceene 2015-03-07 17:42

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by freemangordon (Post 1463331)
If the object you're calling isOpen on (i.e. this pointer) is invalid ;)

Yeah, but I don't see this object being deleted or freed anywhere... maybe I'm missing something.

freemangordon 2015-03-07 18:13

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463357)
Yeah, but I don't see this object being deleted or freed anywhere... maybe I'm missing something.

you could have heap corruption. or stack corruption if it is allocated on the stack.

ceene 2015-03-07 18:19

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by freemangordon (Post 1463365)
you could have heap corruption. or stack corruption if it is allocated on the stack.

It's just a private member of the class... Shouldn't it be safe?

NerdKnight 2015-03-07 23:53

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463366)
It's just a private member of the class... Shouldn't it be safe?

I can't find anything strange either, remember the crash always happens (al least to me) when there is a bad network connection, maybe something gets corrupted, i dont' know. The last log of Yappari before crashing:
Code:

There was an IO error: Connection closed by server.
Connection closed.
Stopping timers.
Freeing up the connection.
Freeing up the socket.
Yappari will retry the connection in 10 seconds.
Segmentation fault


incrys 2015-03-08 03:54

Re: [Announce] Yappari - New maintainership and new features!
 
This is my last report to crash of yappari:
https://www.dropbox.com/sh/lbosl6w4m...voICJhc7a?dl=0
Thx

ceene 2015-03-08 16:15

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by NerdKnight (Post 1463399)
I can't find anything strange either, remember the crash always happens (al least to me) when there is a bad network connection, maybe something gets corrupted, i dont' know. The last log of Yappari before crashing:
Code:

There was an IO error: Connection closed by server.
Connection closed.
Stopping timers.
Freeing up the connection.
Freeing up the socket.
Yappari will retry the connection in 10 seconds.
Segmentation fault


Can you send me your coredump file alongside the binary with debug symbols you compiled? Maybe I can find something... I don't know, I'll have to check the values of some objects (specifically I want to check at least decodedStream and decodedBuffer).

Thank you!

freemangordon 2015-03-08 17:43

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463366)
It's just a private member of the class... Shouldn't it be safe?

without having the coredump file it is hard to say what exactly has happened. However, "segmentation fault" means access to invalid memory location.

ceene 2015-03-08 19:23

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by freemangordon (Post 1463443)
without having the coredump file it is hard to say what exactly has happened. However, "segmentation fault" means access to invalid memory location.

Yep, but being that a statically allocated object I fail to see the reason... anyway, let's wait for Nerdknight to send us the coredump. Let's hope once we analyze it we'll solve this fast :)

newone2 2015-03-08 20:24

Re: [Announce] Yappari - New maintainership and new features!
 
Hi Ceene,
i just want to ask if you will need another coredump or is the coredump from Nerdknight enough?
If you need another one, let me know. cause i still haven't install it yet. I will try to install it tommorow, when i have a little bit more time.

bw Thanks for all your work. ;-)

ceene 2015-03-08 20:48

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by newone2 (Post 1463463)
Hi Ceene,
i just want to ask if you will need another coredump or is the coredump from Nerdknight enough?
If you need another one, let me know. cause i still haven't install it yet. I will try to install it tommorow, when i have a little bit more time.

bw Thanks for all your work. ;-)

I believe Nerdknight's may be enough, that's why I finally didn't release a debug symbols enabled version, but thanks nonetheless. If the need arises I will know to ask you :)

Best regards!

NerdKnight 2015-03-09 00:48

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463439)
Can you send me your coredump file alongside the binary with debug symbols you compiled? Maybe I can find something... I don't know, I'll have to check the values of some objects (specifically I want to check at least decodedStream and decodedBuffer).

Thank you!

I been testing this patch:
Code:

diff --git a/src/yappari-application/Whatsapp/bintreenodereader.cpp b/src/yappari-application/Whatsapp/bintreenodereader.cpp
index 6d32774..3c10fcf 100644
--- a/src/yappari-application/Whatsapp/bintreenodereader.cpp
+++ b/src/yappari-application/Whatsapp/bintreenodereader.cpp
@@ -55,9 +55,6 @@ bool BinTreeNodeReader::getOneToplevelStream()
    }
 
    //qDebug() << "[[ " + readBuffer.toHex();
-    if (decodedStream.isOpen()) {
-        decodedStream.close();
-    }
 
    if (decodeRawStream(flags, 0, bufferSize)) {
        decodedStream.setBuffer(&decodedBuffer);
@@ -146,6 +143,9 @@ bool BinTreeNodeReader::nextTree(ProtocolTreeNode& node)
    node.setSize(getOneToplevelStreamSize());
 
    result = nextTreeInternal(node);
+    if (decodedStream.isOpen()) {
+        decodedStream.close();
+    }
    Utilities::logData("INCOMING:\n" + node.toString());
    return result;
 }

here I close the stream as soon the node reading is complete, so it doesn't need to be checked if it is open when I need to read a new one (I think this makes more sense).
I'm running Yappri with this patch for a day connecting to several different networks and no crashes so far.
To compile with debugging symbols, I add the following to yappari-aplication.pro (remember to revert it in production)
Code:

diff --git a/src/yappari-application/yappari-application.pro b/src/yappari-application/yappari-application.pro
index 761c7c7..0c9c0ab 100644
--- a/src/yappari-application/yappari-application.pro
+++ b/src/yappari-application/yappari-application.pro
@@ -34,7 +34,7 @@
 #-------------------------------------------------

 QT          += core gui network sql maemo5 phonon
-CONFIG      += mobility qtdbus network link_pkgconfig
+CONFIG      += mobility qtdbus network link_pkgconfig debug
 MOBILITY    = systeminfo messaging
 PKGCONFIG  += libosso-abook-1.0 libebook-1.2 gtk+-2.0 gstreamer-0.10 libpulse libexif
 INCLUDEPATH += /usr/include/libosso-abook-1.0 /usr/include/evolution-data-server-1.4/ /usr/include/gtk-2.0 /usr/include/gstreamer-0.10

then run the script src/test_build.sh, this will create the directory build-scratchbox, the you can copy src/build-scratchbox/yappari-application/Yappari to your n900, install gdb in your n900 an run Yappari with gdb Yappari, the executable will be al little bigger (above 30M).
I haven't installed sp-rich-core yet, so I have no coredumps, but I think with gdb I can gather as much information. If it crashes again I'll send you more.

fffffred 2015-03-09 01:06

Re: [Announce] Yappari - New maintainership and new features!
 
Hi,

Anyone having issues with Group Info not displaying all the actual participants?

I have a group that was created back in 2013 Owned by myself. I wish to remove some older participants, but their details are not showing up for me to remove... In fact, I only have 1 participant on my list and this person was added post updates.

Do you require log to assess this situation?

Regards,
Fred

coderus 2015-03-09 04:43

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by fffffred (Post 1463485)
Hi,

Anyone having issues with Group Info not displaying all the actual participants?

I have a group that was created back in 2013 Owned by myself. I wish to remove some older participants, but their details are not showing up for me to remove... In fact, I only have 1 participant on my list and this person was added post updates.

Do you require log to access this situation?

Regards,
Fred

details can be showed only when you add person to your phonebook and synced.

Ast007 2015-03-09 11:48

Re: [Announce] Yappari - New maintainership and new features!
 
I cant seem to delete two chats. There is no1 in the group at all. Any ideas?

+

Will we be getting The Voice call function?

fenik2089 2015-03-14 06:36

Re: [Announce] Yappari - New maintainership and new features!
 
again the problem with authorization in yappari today asked for the phone number and code is not sent

aim120 2015-03-14 07:06

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by fenik2089 (Post 1464007)
again the problem with authorization in yappari today asked for the phone number and code is not sent

I have the same problem as well.

hanie 2015-03-14 08:14

Re: [Announce] Yappari - New maintainership and new features!
 
What's happen again?! :(

coderus 2015-03-14 08:42

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by Ast007 (Post 1463517)
Will we be getting The Voice call function?

I don't think so, unless anybody experienced in voip protocol can help us to reverse whatsapp functions.

Quote:

Originally Posted by hanie (Post 1464011)
What's happen again?! :(

S40 client v2.12.68 is out, Yappari need to update tokens: https://coderus.openrepos.net/whites...atsapp_scratch

NeedKeyboardAndLinux 2015-03-14 08:50

Re: [Announce] Yappari - New maintainership and new features!
 
Thank you, I will check later. But I fear that sooner or later WhatsApp kicks our client.

coderus 2015-03-14 09:07

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by NeedKeyboardAndLinux (Post 1464015)
Thank you, I will check later. But I fear that sooner or later WhatsApp kicks our client.

No, they can do it only if developer is idiot.

hanie 2015-03-14 09:34

Re: [Announce] Yappari - New maintainership and new features!
 
I can't update that, do you have same problem?

Anonind 2015-03-14 10:41

Re: [Announce] Yappari - New maintainership and new features!
 
Same with me.

ceene 2015-03-14 14:58

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by coderus (Post 1464017)
No, they can do it only if developer is idiot.

I couldn't swear that Yappari's maintainer is not an idiot, though...

An upgrade is to be expected today, people, but please stop posting that you can't upgrade because upgrade is not ready yet, so please don't pollute the thread with repeated messages.

coderus 2015-03-14 15:06

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1464040)
I couldn't swear that Yappari's maintainer is not an idiot, though...

An upgrade is to be expected today, people, but please stop posting that you can't upgrade because upgrade is not ready yet, so please don't pollute the thread with repeated messages.

Of course not, that is exactly what i meant :)

ceene 2015-03-14 15:24

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by coderus (Post 1464041)
Of course not, that is exactly what i meant :)

I see on your whatsapp_scratch file the new timestamp, that matches with decompiled WhatsApp_2_12_68.jar, but BUILD_KEY seems to have changed as well...

What I see now is (localObject = new kz()).e(lp.a(lp.c(new byte[] { 67, 119, 82, 33, 87, 89, 106, 88, 124, 70, 97, 100, 95, 100, 34, 81, 116, 37, 86, 90, 123, 105, 123, 38, 35, 33, 119, 85, 42, 125, 124, 65, 42, 102, 85, 80, 127, 127, 84, 120 }) + 1425519131591L + this.hi, false));
which doesn't match PdA2DJyKoUrwLw1Bg6EIhzh502dF9noR9uFCllGk

Can you confirm that I'm not in fact an idiot, please? :)

coderus 2015-03-14 16:35

Re: [Announce] Yappari - New maintainership and new features!
 
yes you doing something wrong
Code:

>>> print ''.join(map(chr,  map(lambda x: x ^ 19, (67, 119, 82, 33, 87, 89, 106, 88, 124, 70, 97, 100, 95, 100, 34, 81, 116, 37, 86, 90, 123, 105, 123, 38, 35, 33, 119, 85, 42, 125, 124, 65, 42, 102, 85, 80, 127, 127, 84, 120))))
PdA2DJyKoUrwLw1Bg6EIhzh502dF9noR9uFCllGk


ceene 2015-03-14 16:52

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by coderus (Post 1464045)
yes you doing something wrong
Code:

>>> print ''.join(map(chr,  map(lambda x: x ^ 19, (67, 119, 82, 33, 87, 89, 106, 88, 124, 70, 97, 100, 95, 100, 34, 81, 116, 37, 86, 90, 123, 105, 123, 38, 35, 33, 119, 85, 42, 125, 124, 65, 42, 102, 85, 80, 127, 127, 84, 120))))
PdA2DJyKoUrwLw1Bg6EIhzh502dF9noR9uFCllGk


Ups. Thank you a lot! I totally forgot about the xoring, so of course nothing came out of it. I should save that script once and for all.

Well, we'll have an updated version in a few minutes.

coderus 2015-03-14 16:59

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1464047)
Ups. Thank you a lot! I totally forgot about the xoring, so of course nothing came out of it. I should save that script once and for all.

Well, we'll have an updated version in a few minutes.

my script on server extract data from new version (if changed) once a day, so you can not worry about it and get always good data from my page :)

nagarendra 2015-03-14 18:40

Re: [Announce] Yappari - New maintainership and new features!
 
guys...... any updates on new version.... ????? ..... still we are unable to download the new version.....

Ast007 2015-03-14 18:42

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by nagarendra (Post 1464063)
guys...... any updates on new version.... ????? ..... still we are unable to download the new version.....

Its getting uploaded, hold tight =)


All times are GMT. The time now is 15:33.

vBulletin® Version 3.8.8