maemo.org - Talk
Page 16 of 72 « First 61415 16 171826 Last »
Show 40 post(s) from this thread on one page

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   [SFOS] [Announce] Rockpool - Pebble daemon for Sailfish (https://talk.maemo.org/showthread.php?t=96490)

ruff 2016-03-31 06:10
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
yeah, i think this is it, see https://developer.pebble.com/guides/...#account-token
Quote:
If the user is not logged in, the token will be an empty string
Since we don't give users ability to login - the accounToken is always empty, and the current implementation is faking it:
Code:
    // We do not have any account system, so we just fake something up.
...
    if (token.isEmpty()) {
        token = QUuid::createUuid().toString();
It means all apps relying on account token won't work till we fix that. It also means that current implementation guarantees anonymity %)
unfortunately my mitmproxy dump from android has been done with already logged in account, so I don't have that exchange captured. Need to re-iterate the process.
BTW it was the same on pebbled, the implementation in jskitobjects.cpp is identical,

abranson 2016-03-31 07:50
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Supporting accounts would need support in the QML appstore client, and then in libpebble to remember the account id and make it available to apps. Both of those should probably be done in collaboration with RockWork - I don't want to keep fairly in line with that so we can both benefit from bug fixes on either side.

From a libpebble standpoint the code would probably be identical in RockWork and RockPool, but what about the appstore client?

Quote:
Originally Posted by ruff (Post 1502491)
BTW it was the same on pebbled, the implementation in jskitobjects.cpp is identical,
I think some people believe that there's not much of Pebbled left in RockWork. A lot has been replaced and refactored, but it's important to appreciate that is it really still a fork, and those guys deserve contribution credit.

HtheB 2016-03-31 08:54
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Quote:
Originally Posted by ruff (Post 1502491)
yeah, i think this is it, see https://developer.pebble.com/guides/...#account-token

Since we don't give users ability to login - the accounToken is always empty, and the current implementation is faking it:
Code:
    // We do not have any account system, so we just fake something up.
...
    if (token.isEmpty()) {
        token = QUuid::createUuid().toString();
It means all apps relying on account token won't work till we fix that. It also means that current implementation guarantees anonymity %)
unfortunately my mitmproxy dump from android has been done with already logged in account, so I don't have that exchange captured. Need to re-iterate the process.
BTW it was the same on pebbled, the implementation in jskitobjects.cpp is identical,
What about like an option to enable it for those who doesn't care about privacy? :D
(Joke aside, I would love to get some apps to work :( )

abranson 2016-03-31 09:16
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Yep it should be on the to-do list, and I think as the docs say it should be empty if the user isn't logged in, rather than a random string. It'll have to be discussed with the RockWork guys though. A common implementation would be better.

ruff 2016-03-31 10:51
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Quote:
Originally Posted by abranson (Post 1502494)
From a libpebble standpoint the code would probably be identical in RockWork and RockPool, but what about the appstore client?
We're also reusing native code implementation from rockwork mostly, of course we have own platfrom layer in main.cpp but the rest is mostly as-is. We can rename main.cpp to rockpool.cpp to avoid conflicts and then keep rest of the code shared.
Our QML part is also independent now since we've moved it to sailfish-specific dirs (pages/covers).
It's a pity we don't have track log for bazaar - so we cannot say what actually changed since initial import. And unfortunately during the initial import you didn't preserve original state so we also don't have a track of how far we deviated from them during the import.
From what I can see we have only servicecontrol.cpp, pebble.cpp and main.cpp (of course) changed since initial import.
These are topics to settle down if we targeting the merge though.

abranson 2016-03-31 11:42
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Quote:
Originally Posted by ruff (Post 1502512)
We're also reusing native code implementation from rockwork mostly, of course we have own platfrom layer in main.cpp but the rest is mostly as-is. We can rename main.cpp to rockpool.cpp to avoid conflicts and then keep rest of the code shared.
Our QML part is also independent now since we've moved it to sailfish-specific dirs (pages/covers).
It's a pity we don't have track log for bazaar - so we cannot say what actually changed since initial import. And unfortunately during the initial import you didn't preserve original state so we also don't have a track of how far we deviated from them during the import.
From what I can see we have only servicecontrol.cpp, pebble.cpp and main.cpp (of course) changed since initial import.
These are topics to settle down if we targeting the merge though.
Bzr and Git can co-exist in the same directory if you want to explore the differences. That's what I do to push changes back to RockWork. Pull from git, sync some changes, push to launchpad. Of course that doesn't cope when the files have been moved.

ruff 2016-03-31 11:50
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Oh, excellent, so you should be in a better position to say what has changed :)
We can probably merge pebble and servicecontrol files, just need to move service name definition to some external file, bcz changes there are mostly fixes (missing calls).
We could even make libpebbleclient.so lib and strip down platform part to mere initialization.

abranson 2016-03-31 12:04
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Quote:
Originally Posted by ruff (Post 1502517)
Oh, excellent, so you should be in a better position to say what has changed :)
We can probably merge pebble and servicecontrol files, just need to move service name definition to some external file, bcz changes there are mostly fixes (missing calls).
We could even make libpebbleclient.so lib and strip down platform part to mere initialization.
I would be if you hadn't moved all the qml files :p

ruff 2016-03-31 12:21
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
But QMLs are out of the scope, they are all different and platform specific, you can return original qml files from bazaar if bzr is complaining - original were in the client's root folder(rockwork).

abranson 2016-03-31 13:46
Re: [Announce] Rockpool - Pebble daemon for Sailfish
 
Quote:
Originally Posted by ruff (Post 1502521)
But QMLs are out of the scope, they are all different and platform specific, you can return original qml files from bazaar if bzr is complaining - original were in the client's root folder(rockwork).
Ok, so if we implemented an account login in our version of the store client, it wouldn't be very useful to RockWork?


All times are GMT. The time now is 21:56.
Page 16 of 72 « First 61415 16 171826 Last »
Show 40 post(s) from this thread on one page

vBulletin® Version 3.8.8