maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   Quickddit for SailfishOS (https://talk.maemo.org/showthread.php?t=92222)

dicksonleong8 2014-02-11 10:42

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by NoGeist (Post 1412046)
Great app!

Is there a way to minimize the children in the comment section? If not, a longpress on the parent would be great or if it could be added to the actions when clicking the parent one time (upvote, downvote etc.)

I'd like that there would be a cover action to refresh the current page and it would open that page.

Another suggestion would be, that you could swipe right and get to the section or subreddits, as someone else suggested earlier.

Collapsing children comments is on my todo list :) but it will take some time to implement. Cover action too.

Quote:

Originally Posted by szopin (Post 1412052)
Like the horizontal swipe menus in IRC would work great

Swiping left and right gesture is reserved for navigating forward or backward from page to page, so this is not a good design for Silica app.


On the other news, reddit recently has some minor changes and unfortunately this break some of the code in Quickddit, which causes you have to re-login everytime starting the app. I will release a fix very soon.

szopin 2014-02-11 11:00

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1412160)
Swiping left and right gesture is reserved for navigating forward or backward from page to page, so this is not a good design for Silica app.

There is nowhere backwards/right to navigate from main screen, subreddits in pulley-right menu would make if not silica sense a lot of usability sense

parasemic 2014-02-11 11:04

Re: Quickddit for SailfishOS
 
I'm with szopin in this one. I think it would be by far easiest way to browse subreddits, however if you dont like the idea, so be it.

nodevel 2014-02-11 11:15

Re: Quickddit for SailfishOS
 
Sorry for being offtopic here, but what's in the IRC client (great app otherwise) are no horizontal puley menus. Nothing can be selected in them by pulling; it's just an overlay that mimics the look of pulley menus, which is quite confusing (maybe it's just me, but having every side of the screen glowing doesn't sound very intuitive).

The exact same behavior could be done by having pages left and right of the current view. The same applies to this reddit client. I'm with dicksonleong8 here.

Why break the silica logic, when you can achieve tthe same thing better using the current guidelines...

szopin 2014-02-11 11:33

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by nodevel (Post 1412177)
Sorry for being offtopic here, but what's in the IRC client (great app otherwise) are no horizontal puley menus. Nothing can be selected in them by pulling; it's just an overlay that mimics the look of pulley menus, which is quite confusing (maybe it's just me, but having every side of the screen glowing doesn't sound very intuitive).

Yeah, they don't 'click' but I've been successfully selecting which irc channel to join/switch to, which person to msg etc, for a long list of choices it is much better/easier to use than pulley way (or maybe my thumb is too short)

Quote:

Why break the silica logic, when you can achieve tthe same thing better using the current guidelines...
Exactly because current guidelines do not offer anything else than pulley to select a menu option where you have extra click to select for long lists, why if IRC guys introduced a cool way to interact with long lists?
(I guess swipe left for page with subreddits would be ok with guidelines and have exactly the same functionality, except silica dot to indicate that you can go right and not the highlighted side, you're not navigating inwards without selecting anything anyway)

extra edit just to end my rant: silica guidelines are ok for mobile apps with few choices, try to implement silica/pulleys for QT Creator/Transmission/GIMP, with many choices pulley just sucks or needs workaround to hide all settings under a few choices, for often used options that just doesn't work, just imagine chatting with few people on IRC at the same time having to pulley each time to select 'msg' then to select the guy, not only does the left/right pulley give you info who msged you with colour but removes all that burden (and then add chatting on few channels, SW keyboard is a pain already, but I've been using IRC normally/dektop-like on N900 and with HWKB I expect the same from Jolla) /rant

parasemic 2014-02-11 11:59

Re: Quickddit for SailfishOS
 
I don't understand why you say it breaks the UI. In sailfish, apps consist of main screen, and other screens that are on the right side, navigated forward by clicking and going back by swiping. There is no action for swiping "back" in first/main screen, or other side in the last screen.
Filling that "empty" slot with having an easily scrollable list or useful items, such as channels in irc or subs in reddit seems really clever and intuitive for me. Whole concept of pulley menus is brilliant so why not extend it for browsing long lists instead of having them in a separate and awkwardlooking page?

dicksonleong8 2014-02-11 12:10

Re: Quickddit for SailfishOS
 
I think you are talking about 2 different design: one is exactly like the IRC one, which is basically a horizontal pulley menu. Another one is new page by swiping left (as suggested by mikecomputing), indicate by the extra dot at the top left (we call this an "attached page"). The first one is not a good design and violating the UI logic of Sailfish app, while the second one is a perfectly good design.

I'm not able to implement the "attached page" design yet because it is not working properly in emulator (hopefully will be fix in next SDK update). I will try to improve the design so that user can access subreddits much easier, but the horizontal pulley menu is a no go.

Finally, I releasing 0.3.1 for fixing the login bug, with some minor bugs fix and improvements. As usual, update from OpenRepos and changelog from GitHub.

parasemic 2014-02-11 13:10

Re: Quickddit for SailfishOS
 
I understand your point, but disagree with it. For my understanding, apps in sailfish aren't supposed to have any pages to the left while starting it. Either way, as I said Im just stating my opinion and not trying to push anything. :) However, I really like the menus in irc and think they fit sailfish perfectly, and should be a part of the standard UI.

e: Great that you have fixed the login issue!

szopin 2014-03-17 21:03

Re: Quickddit for SailfishOS
 
w00t is willing to helpbon the qt/qml bug with pics:
http://talk.maemo.org/showpost.php?p...&postcount=492

parasemic 2014-03-18 13:47

Re: Quickddit for SailfishOS
 
If a vertical "pulley" isnt an option, id like to see a few subreddits pinnable in the main pulley

szopin 2014-04-04 18:28

Re: Quickddit for SailfishOS
 
Turns out most tweaks can be done without recompilation. For landscape support just add
Code:

allowedOrientations: Orientation.All
right after page id in share/harbour-quickddit/qml/*.qml files you want to support landscape. With this comes the fact that system turning does fitToScreen correctly, pardon tweetpics:
how it loads originally
http://t.co/ol0FPTH45M
after turning sideways and back to portrait
http://t.co/D76JcFVexz
(if anyone knows better/easier way to post screenshots from jolla pls share)
after orientation switching swipe back to comments works without hitches, any suggestions how to make it scale properly from initial load? the only noticeable diffs in the image viéw qml (comparing to veskuh's tweetian) were triple = which did not do the trick

thejus11 2014-04-09 11:29

Re: Quickddit for SailfishOS
 
Is there a way to save posts? Couldn't find one, and this is an important feature!

dicksonleong8 2014-04-18 01:11

@szopin that's an interesting discovery. Unfortunately the emulator does not support switching to landscape mode, so I can't test that or create a workaround :(

@thejuz11 on my todo list but not high priority.

thejus11 2014-04-18 07:13

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1421768)
@szopin that's an interesting discovery. Unfortunately the emulator does not support switching to landscape mode, so I can't test that or create a workaround :(

@thejuz11 on my todo list but not high priority.

Sorry if this is obvious, but do reddit messages notifications work?

dicksonleong8 2014-05-19 07:07

Re: Quickddit for SailfishOS
 
Updated to 0.3.2!

- Add support for viewing image from more formats of Imgur URL
- Add support for view, add and remove subreddits for multireddit
- Add support for search within a subreddit
- Show number of hidden comments (show additional comments is not implemented yet)
- Add refresh action for cover
- Redesign open link dialog UI
- A lot of minor UI fixes
- "Front Page" and "Sureddits" options move from "More" to the pull down menu for easier access
- Fix image not fit to screen
- Fix a possible crash when performing multiple request at startup
- Show a message after added/edited/deleted a comment successfully

Update from OpenRepos

nodevel 2014-05-19 07:50

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1425921)
Updated to 0.3.2!

Thank you!
I have just two suggestions:
  • could you please reduce the number of items in pulley menu (i.e. in subreddits) to 4, as recommended by Jolla? You could solve it by, for example, moving the subbreddit info to an attachedPage.
  • what about saving favorites? I don't have a reddit account, but I would like to be able to favorite some threads to come back to it later.

dicksonleong8 2014-05-19 17:24

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by nodevel (Post 1425927)
Thank you!
I have just two suggestions:
  • could you please reduce the number of items in pulley menu (i.e. in subreddits) to 4, as recommended by Jolla? You could solve it by, for example, moving the subbreddit info to an attachedPage.
  • what about saving favorites? I don't have a reddit account, but I would like to be able to favorite some threads to come back to it later.

AttachedPage not working reliably (at least in the emulator), so I can't use that (for now). A lot of people complaining that they need to access to the subreddits option faster, so I have to move it out from "More" to the pull down menu. 6 items not that worst, IMO.

With a reddit account you can "save" a thread or a comment, but I have not implement yet (in my todo!). But without an account... Quickddit is design for user with a reddit account so I don't think I will implement that.

nodevel 2014-05-20 07:08

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1425993)
AttachedPage not working reliably (at least in the emulator), so I can't use that (for now). A lot of people complaining that they need to access to the subreddits option faster, so I have to move it out from "More" to the pull down menu. 6 items not that worst, IMO.

That is certainly a matter of opinion, but those guidelines exist for a reason. Once you force allowedOrientations in Silica (for example when using the dirkvl's keyboard), any more than 4 items in pulley menu are unusable. I think that it applies for portrait as well.

What is the problem with attachedPage? I have used it in some of my apps and it works fine. Just tried it in the emulator as well as on the device and works great on both. You just need to do (replace attachedPageId with the id of your own attached page):
Code:

onStatusChanged: {
    if (status === PageStatus.Active) {
        pageStack.pushAttached(attachedPageId)
    }
}



I also forgot about one thing that is quite annoying: Could you please change the color of links (like it was done in Tweetian)? The default blue color is unreadable in Sailfish.
Thank you.

magullo 2014-05-20 09:29

Re: Quickddit for SailfishOS
 
Do you think to publish quickddit on Harbour?
Thanks

parasemic 2014-05-26 09:41

Re: Quickddit for SailfishOS
 
Landscape support would be awesome!

dicksonleong8 2014-05-29 07:08

Re: Quickddit for SailfishOS
 
@nodevel I managed to implement it correctly, pushed the changes to GitHub, if you wanna test you can built yourself :)

@magullo yes, but only when it is stable and out of beta, which means long way to go. Also, AFAIK, harbour doesn't provide the download statistics yet, so really no incentive to publish to harbour for now.

@parasemic emulator does not support landscape yet, so I can't test and enable it for now. You can manually enable it by editing the QML file though (see here).

mattaustin 2015-04-11 08:27

Re: Quickddit for SailfishOS
 
Hi - thanks for this app - I use it almost every day!

I'm not sure if there is still ongoing development, but I have two suggestions / feature requests which I think would be great if they could be included with the next update:

1) Fix image zoom - I think this used to work, but it broke with the Sailfish OS update to Qt 5.2.

2) Support for 'gifv' playback, currently an error message is shown when selecting a imgur link to a 'gifv' file, and it has to be opened in a browser to view it. It would be great to get playback directly in the app, but another workaround would be to just automatically modify the link to strip off the trailing 'v', and load the normal (but larger) 'gif' version instead.

szopin 2015-04-11 11:56

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by mattaustin (Post 1466362)
1) Fix image zoom - I think this used to work, but it broke with the Sailfish OS update to Qt 5.2.

You can either do the three finger workaround (just place third finger and then zoom, bit wonky but works), or edit /usr/share/harbour-quickddit/qml/ImageViewPage.qml file, after NumberAnimation definition in PinchArea (around line 180 for me) add:
Code:

            Rectangle {
                opacity: 0.0
                anchors.fill: parent
            }

This fixes it for good

(based on this commit by veskuh that fixed tweetian: https://github.com/veskuh/Tweetian/c...77e2483f735113)

mattaustin 2015-04-11 12:17

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by szopin (Post 1466386)
This fixes it for good

Thanks! That did the trick!

I created a pull request with this patch in too: https://github.com/dicksonleong/Quickddit/pull/12

dicksonleong8 2015-04-15 17:54

Re: Quickddit for SailfishOS
 
Unfortunately I still not able to get a Jolla here (Malaysia). I like SailfishOS but I really don't have that much of interest to continue develop an app for a device I don't own. So I apologise for all the users who used my apps and waiting for an update.

Luckily, Quickddit at its current state is still pretty usable with all those basic functions implemented. Maybe someday other developer can take over this project... (remember it is open source!)

nodevel 2015-04-15 19:34

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1467289)
Unfortunately I still not able to get a Jolla here (Malaysia). I like SailfishOS but I really don't have that much of interest to continue develop an app for a device I don't own. So I apologise for all the users who used my apps and waiting for an update.

Luckily, Quickddit at its current state is still pretty usable with all those basic functions implemented. Maybe someday other developer can take over this project... (remember it is open source!)

I am speechless - I didn't even imagine that the author of the most feature-complete app on SailfishOS is not even a Jolla owner.

What about setting up a crowdfunding campaign? It worked well for other developers and I think you could be then able to get one from India or EU (using some TMO user or re-shipping services).

I don't really miss any functionality in Quickddit, but it's a shame you had to develop it without a device, using only the SDK. Thank you again for such a great app!

szopin 2015-04-17 16:43

Re: Quickddit for SailfishOS
 
It is a shame, but things might get better in near future:
Code:

On Thu Apr 16 07:27:46 2015 GMT+0200, Karl Granström wrote:
> Hi,
>
> We are still working hard on it but the tablet support work has been eating our resources from this area. But some good news is that we are planing to launch the donation support in Store in really near future.
>
> Br,
> Karl

Then again the app itself could have donate option even without store support for it (or maybe offer a donation drive, list some features and let people donate for the ones they lack most and every milestone from donations reached implement it? would chip in a tenner for 'hide' of junk comment branches, luckily scrolling got a lot smoother in last update)

JustDevZero 2015-04-28 01:54

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by dicksonleong8 (Post 1467289)
Luckily, Quickddit at its current state is still pretty usable with all those basic functions implemented. Maybe someday other developer can take over this project... (remember it is open source!)

My trainer always told me that "someday, is not a day of the week".

But was just that day (Monday 27, my birthday) that I found your app.

Really interesting, indeed I already made a fork in github (I'm sure you'll notice it), and well...

I'm studying the code to improve the app and continue it in my way :)

Ofc, still opensource and will mantain credit to your self.

accumulator 2015-06-22 08:58

Re: Quickddit for SailfishOS
 
Hi all,

I haven't posted here (much) but I've been a happy user of the N900, N9 and now the Jolla phone. I came across the wonderful Quickddit app made by dicksonleong and to my horror I found out he's not maintaining it anymore!

So I decided to pick up development, primarily for the Jolla, since that's my main phone, but also for the N9 because I still have one lying around and porting most features is not too much extra work.

I've just made a new release, 0.4.0, that adds the following features:
* Load more comments feature implemented
* Show author in italics when it has special status (submitter, admin, moderator)
* show link flair
* focus TextArea automatically in TextAreaDialog
* fix UI link voting in comments page
* links are now colored according to theme

I've published my version here on OpenRepos

Edit: when installing the new version, you'll have to log in again because the app (of course) has a different reddit oauth client ID

tadzik 2015-06-22 10:10

Re: Quickddit for SailfishOS
 
Thank you so much for picking this up! Link coloring was the single most annoying thing for me, you just made my experience a whole lot better :) Kudos to you, good sir, keep up the good work!

billranton 2015-06-22 12:43

Re: Quickddit for SailfishOS
 
Brilliant work, thanks! Are you planning to get it in the harbour?

accumulator 2015-06-22 14:28

Re: Quickddit for SailfishOS
 
Yes it's in the QA queue right now

ilpianista 2015-06-22 15:46

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by accumulator (Post 1474401)
* links are now colored according to theme

THIS!

Thank you!

BTW, just wondering, did you ask dicksonleong before pushing to OpenRepos and Jolla Store?

tadzik 2015-06-22 16:16

Re: Quickddit for SailfishOS
 
It's now showing up in Jolla Store :)

And since I already posted: I noticed that pressing Play on a finished gifv redownloads it, or so the animation suggests. Could this be fixed? Thanks in advance :)

accumulator 2015-10-02 10:10

Re: Quickddit for SailfishOS
 
update imminent :)

szopin 2015-10-06 18:15

Re: Quickddit for SailfishOS
 
Thank you sooooo much!!!!! (hint: long press a comment to hide whole circlejerky thread, works so nicely)

Have to ask though, anyone getting images stuck at 0% and never loading. Playing today with network monitor noticed there is bandwidth used in the background, so it looks like quickddit issue (happens rarely fresh after start, then becomes persistent like every second pic won't load, you can retry few times and eventually it will load, open in browser works every time so think it is quickddit bug)

accumulator 2015-10-07 09:38

Re: Quickddit for SailfishOS
 
Hah, good, you found the long press functionality. I was slightly worried if it was discoverable enough. And I'm not really planning to start writing a manual.

Regarding image and video previews, yes, there's some issues there. I haven't seen exactly what you describe, but I've seen videos playing choppy while showing 0-1% progress, or images not displaying if their size is too big. I'll have to dig a bit deeper in AnimatedImage and related QML types to see if I can poke them in a better way.

szopin 2015-10-07 17:00

Re: Quickddit for SailfishOS
 
The black issue on big images throws this I believe:
Code:

[W] qt_png_warning:499 - libpng warning: iCCP: known incorrect sRGB profile
[D] CustomContext::HybrisTexture::bind:313 - Error after glEGLImageTargetTex
ture2DOES 501

Tested with Tweetian and image that bugs out in quickddit worked fine there. Tweetian uses Image rather than AnimatedImage though

mattaustin 2015-10-08 04:36

Re: Quickddit for SailfishOS
 
Thanks very much for the updates!

One issue I've noticed (just a small annoyance really), is that whichever network connection is in use when the app is first run becomes the only connection that the app will attempt to use.

If I have the app running, and leave home, and the phone switches from WLAN to mobile data, I have to quit and reload before the fetching of any network resources (comments/images/posts etc.) works again.

accumulator 2015-10-08 20:11

Re: Quickddit for SailfishOS
 
Quote:

Originally Posted by szopin (Post 1484610)
[D] CustomContext::HybrisTexture::bind:313 - Error after glEGLImageTargetTex
[/code]

Tested with Tweetian and image that bugs out in quickddit worked fine there. Tweetian uses Image rather than AnimatedImage though

Exactly right. The QML Image object has the sourceSize.X and Y properties that can scale the source to within what GL can take. AnimatedImage made those properties read-only, so we can't preprocess what gets sent to GL unfortunately. Hence the HybrisTexture error.

Currently, it's a choice between showing a static image always, or animated image always but with big picture bugged.

That, or fetching the image first, analyze it, and show one of Image/AnimatedImage. In other words, it's hard to work around, it should be fixed in AnimatedImage.

Quote:

Originally Posted by mattaustin (Post 1484645)
Thanks very much for the updates!

One issue I've noticed (just a small annoyance really), is that whichever network connection is in use when the app is first run becomes the only connection that the app will attempt to use

It's only Qt http I use, if there's any networking quirks popping up, it's unlikely something quickddit specific. I personally haven't had any problems switching between wifi and 3g


All times are GMT. The time now is 09:13.

vBulletin® Version 3.8.8