maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   [Announce / WIP] Theme Customizer (https://talk.maemo.org/showthread.php?t=62960)

riot_heroes 2011-11-18 14:49

Re: [Announce / WIP] Theme Customizer
 
the video cam stuttering problem ? Are there any fix from nokia ?

bennypr0fane 2012-05-14 10:35

Re: [Announce / WIP] Theme Customizer
 
Hello,
I'm using the fast transitions with CSSU Testing 3.1
I'd like to force rotate applications that don't do portrait mode. I think to do this, I need to use the transitions.ini from CSSU, but then I don't get to use the amazing, wonderful, magnificently fast transitions of Theme Customizer. Is there any way to get both?
Wouldn't it be possible to merge CSSU's code for portrait mode into your transitions? Or rather, make your transitions part of CSSU. I think they absolutely belong upstream.
thanks, Ben

seanmcken 2013-02-23 13:42

Re: [Announce / WIP] Theme Customizer
 
cant change size of icons and cant remove that application background shortcut

sixwheeledbeast 2013-02-23 16:25

Re: [Announce / WIP] Theme Customizer
 
DO NOT use theme customizer is it a broken package.
It installs and old version of hildon-desktop that can cause chaos.
It's not compatible with later versions of CSSU due to this.

http://wiki.maemo.org/Community_SSU/...roken_packages

Would be nice if it could be fixed.

ade 2013-03-06 19:45

Re: [Announce / WIP] Theme Customizer
 
There has been some discussion about how "broken" this package would be, in the light of the current cssu state.
Looking at it more closely (version 0.9-77, the last extras-devel), I would say it is less broken then some suggest :)

Themes:
I did not test that, but I do not expect something to be broken.
My only concern would be if you have more than the default 4 desktops/wallpapers. Portrait wallpapers are not supported.

Fonts:
Changing fonts is done by search/replace in transitions.ini, so it is not logical that it would be broken. Tested and no issues found.

Font size:
Done by changes in css templates? No issues suspected.

Font colors:
Done by changes in css templates? No issues suspected.

Color changes:
I don not expect cssu has had any impact on this.

Use custom (fast) window transitions:
Could give issues as it uses it's own transitions.ini..

Show app shortcut/app shortcut size/web bookmark size:
This uses a gconftool command, which does no longer have any effect in cssu (tested). That's why it is grayed out in that case.

Snap to grid:
Done by search/replace in transitions.ini, so it is not logical that it would be broken. Tested and no issues found.

Opacity settings:
Tested and no issues found. Also confirmed by thedead1440.

Change backgrounds:
For apps like the mediaplayer. Tested and works fine.

Some remarks:
Theme customizer has it's own hildon-home, which it may use in some restores/backups. But it never uses that file when cssu is found to be installed.

One other point is that is keeps track of some changed settings (like snap to grid size). If you change that value by hand in transition.ini, it will still think it has the old value and will set that value if you decide to save and you did not correct it first.


So I decided to carry out some changes.
  • I added portrait layout support for the various screens. That took about 95% of all the total time I spent on it :(
  • If cssu is installed, the not supported options are now hidden instead of greyed-out
  • Bugfix: theme customizer would crash if nothing was selected and you pressed load in the "Color presets" screen (now the first entry is always selected at start)
  • The custom hildon-home (and related code) is removed, so it should pose no potential risk
  • The option set fast-transitions is removed
  • The included transitions.ini file is removed
  • some references to cssutransitionstuner are removed

As mentioned I did not test it thoroughly, but if you are brave enough to try it at your own risk, you can get the updated version here: theme-customizer_0.9-80_all.deb

markai 2013-03-08 21:22

Re: [Announce / WIP] Theme Customizer
 
Hi, Ade, this are great news!

I trust you tested it with PR 1.3?

ade 2013-03-08 22:05

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by markai (Post 1327740)
Hi, Ade, this are great news!

I trust you tested it with PR 1.3?

I hope you realize we are talking N900 here?

sixwheeledbeast 2013-03-09 08:50

Re: [Announce / WIP] Theme Customizer
 
@ade. Thank you so much for taking the time to repair this package.
It is only my duty to test it :)

A couple of quick notes.
All seems very stable and no obvious chaos on my new thumb/devel setup. Portrait makes a huge difference to the overall app.

One thing that was a pain with theme-customizer was the "keep my existing wallpaper" not being default. IMO it should default to keep existing not use current theme.

Also stock maemo/cssu defaults "snap-to-grid" as 4 whereas theme-customizer seems to default to 8.

Thanks again.

ade 2013-03-09 10:48

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327807)
@ade. Thank you so much for taking the time to repair this package.
It is only my duty to test it :)

A couple of quick notes.
All seems very stable and no obvious chaos on my new thumb/devel setup. Portrait makes a huge difference to the overall app.

One thing that was a pain with theme-customizer was the "keep my existing wallpaper" not being default. IMO it should default to keep existing not use current theme.

Also stock maemo/cssu defaults "snap-to-grid" as 4 whereas theme-customizer seems to default to 8.

Thanks again.

I more than agree on the point that "keep existing wallpaper should be default", as I replaced my own wallpapers by accident a few days ago, forgetting to alter that option :(. Will change that.

Snap to grid values are taken from it's own current config file, so it no real default value. Maybe it has an initial value at installation, or theme depending. I would have to look into that. As I said earlier, it would be best if it would display the current value from transitions.ini itself on startup.

P.s. does anyone know why the options like "no icon background" and "icon size" are not implemented in cssu? As I understand correctly it where some extensions on top of the original hildon-home, that where not incorporated in the cssu version.

Edit: just saw the value for keep "current wallpaper" in portrait is ignored. That may also explain why my wallpapers where replaced. Will fix that as well.

vetsin 2013-03-09 11:44

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1327829)
P.s. does anyone know why the options like "no icon background" and "icon size" are not implemented in cssu? As I understand correctly it where some extensions on top of the original hildon-home, that where not incorporated in the cssu version.

Hi ade!
Thanks for the update. The "no icon background" and "icon size" options work on my N900 which is on CSSU Thumb and version 0.9-65 of Theme Customizer with no problems. Maybe you can look at the older version for reference?

tonyhuynh 2013-03-09 12:15

UT

-via Maemo Talk app

ade 2013-03-09 13:07

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by vetsin (Post 1327844)
Hi ade!
Thanks for the update. The "no icon background" and "icon size" options work on my N900 which is on CSSU Thumb and version 0.9-65 of Theme Customizer with no problems. Maybe you can look at the older version for reference?

Are you sure?

As I see the same commands being used in both versions (0.9-65 and 0.9-77):
Code:

# change sizes:
gconftool -s /apps/osso/hildon-home/task-shortcuts-size -t int <value>
gconftool -s /apps/osso/hildon-home/task-bookmarks-size -t int <value>
# no icon backgrounds:
gconftool -s /apps/osso/hildon-home/task-shortcuts-back -t int 0
# icon background
gconftool -s /apps/osso/hildon-home/task-shortcuts-back -t int 1

When changing the icon background settings to no icon backgrounds, I see no difference, even after a reboot (on cssu-devel).

vetsin 2013-03-09 13:20

Re: [Announce / WIP] Theme Customizer
 
Yup. Here's a screenshot of my desktop which I made when Theme Customizer was discussed in the broken packages thread. As you can see the icons don't have any background and they are smaller than what you'd normally like icons to be since I just tested resizing them.

http://farm9.staticflickr.com/8240/8...5263b302_z.jpg

EDIT:
Are those config options commented out/disabled in the 0.9-77 version when CSSU is installed? Maybe d-ivil just thought that they no longer work when CSSU is installed due to some reports in earlier posts in this thread and decided to just disable them without really checking since he doesn't have the device anymore?

BTW, I'm sure Theme Customizer v 0.9-65 works on CSSU testing since that's where I came from before switching to Thumb.

ade 2013-03-09 13:28

Re: [Announce / WIP] Theme Customizer
 
Could you try to put the background back as a test? It could have been accomplished another way, by removing some PNG files.

I will test the resize, as I only tested the icon backgrounds.

ade 2013-03-09 13:56

Re: [Announce / WIP] Theme Customizer
 
I can tell you why it works in your case:
Version 0.9-65 will always overwrite hildon-home, with it's own version that supports these features.

Later versions do not overwrite hildon-home when cssu is detected.
As I now installed version 0.9-65, these option do now work at my device.

But as I don't know the exact impact, I am going to restore my cssu hildon-home.

Conclusion: these features are not supported in cssu (hildon-home).

vetsin 2013-03-09 14:07

Re: [Announce / WIP] Theme Customizer
 
So that clears it up. :)
I just tested it again as you requested and yes it worked for me (had to change widget opacity from zero to something though).
I haven't had any problems with 0.9-65 though I have to admit that I don't change my desktop much (I actually only use 1 desktop w/o any widget) and I only did it now for testing. :)

ade 2013-03-09 14:33

Re: [Announce / WIP] Theme Customizer
 
As a result of the tests/discussions today:

Code:

theme-customizer (0.9-81) stable; urgency=low

* keeping wallpaper settings in portrait now works correctly
* keep current wallpaper now set as default at startup
* current snap-to-grid size now synced with transitions.ini value at startup
* now show extra option (icon size etc) if modified hildon-home is detected

The last point meaning: if the adapted hildon-home is found (equal to the version of 0.9-65), then the extra options are shown, else they are hidden.
theme-customizer_0.9-81_all.deb

sixwheeledbeast 2013-03-09 15:00

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1327829)
Snap to grid values are taken from it's own current config file, so it no real default value. Maybe it has an initial value at installation, or theme depending. I would have to look into that.

I have a newly reflashed device which had "snap to grid" as 4.
After using theme-customizer and only changing the font it has set it to 8.

ade 2013-03-09 15:18

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327884)
I have a newly reflashed device which had "snap to grid" as 4.
After using theme-customizer and only changing the font it has set it to 8.

That is the behaviour I would expect in the older versions (as it relies on it's config file value).

But it should no longer act this way, as it takes the value from transitions.ini. Can you confirm that with the latest version it works correctly?

P.s saving in Theme Customizer means saving all settings, not just the changed ones.

sixwheeledbeast 2013-03-09 17:51

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1327893)
Can you confirm that with the latest version it works correctly?

I can't seem to get it to work correctly (0.9.81).

/opt/usr/share/themes/foo/transitions.ini has not been created.

Manual changes to either (when created /opt/usr...) doesn't update in theme-customizer.

Changes in theme-customizer only edits /opt/usr version even thought it wasn't created. /usr/share/hildon-desktop/transitions.ini doesn't get edited.

AFAIK both need changing if using a custom theme?

ade 2013-03-09 18:41

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327933)
I can't seem to get it to work correctly (0.9.81).

/opt/usr/share/themes/foo/transitions.ini has not been created.

If it is based on the transactions.ini that was included in the old packages that could be the case. I removed that file because there were reports it would overwrite custom settings.

Transition.ini is not really needed in that themes folder, is it? I assume it is for storing the transitions settings set using that theme. I do not have that file in any of my theme folders.

Quote:

Manual changes to either (when created /opt/usr...) doesn't update in theme-customizer.

Changes in theme-customizer only edits /opt/usr version even thought it wasn't created. /usr/share/hildon-desktop/transitions.ini doesn't get edited.

AFAIK both need changing if using a custom theme?
It tries to update (if exists) both the transitions.ini in the themes folder, and the one in /usr/share/hildon-desktop/. I did not alter any of that code.

The update of /usr/share/hildon-desktop/transitions.ini works fine on my device. Both in case /usr/share/hildon-desktop/transitions.ini was altered manually (theme customizer picks up that new value, only from /usr/share/hildon-desktop) and when theme customizer writes it's updates. I have tested this multiple times.

sixwheeledbeast 2013-03-09 19:14

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1327942)
It tries to update (if exists) both the transitions.ini in the themes folder, and the one in /usr/share/hildon-desktop. I did not alter any of that code.

The update of /usr/share/hildon-desktop/transitions.ini works fine on my device. Both in case /usr/share/hildon-desktop/transitions.ini was altered manually (theme customizer picks up that new value, only from /usr/share/hildon-desktop) and when theme customizer writes it's updates. I have tested this multiple times.

Not certain if both definately need updating, is /opt/usr just a theme-customizer thing or do all custom theme go there?

Here it seems if /opt/usr.. exists, /usr/share.. isn't updated?

Also if I edit snap-to-grid manually theme customizer definately doesn't update. :(

Other points
Keep current wallpapers has no selector and the version in About is 0.9.80.

ade 2013-03-09 19:40

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327950)
Not certain if both definately need updating, is /opt/usr just a theme-customizer thing or do all custom theme go there?

Dunno. Like anyone else, I would have to look in the code for an answer.

Quote:

Here it seems if /opt/usr.. exists, /usr/share.. isn't updated?
Your are very right about this one! Then I really need to find out what the purpose of the theme one is and why this choice is made.

Quote:

Also if I edit snap-to-grid manually theme customizer definately doesn't update. :(
I hope you are not expecting some live update while running theme customizer? Because it does not. With what config are you testing (cssu/busybox power etc.)?

Quote:

Other points
Keep current wallpapers has no selector
I am not sure what you mean by that...

Quote:

and the version in About is 0.9.80.
I will put 0.9.81 in the next version :D

sixwheeledbeast 2013-03-09 20:33

Re: [Announce / WIP] Theme Customizer
 
1 Attachment(s)
Quote:

Originally Posted by ade (Post 1327951)
I hope you are not expecting some live update while running theme customizer? Because it does not. With what config are you testing (cssu/busybox power etc.)?


I am not sure what you mean by that...


I will put 0.9.81 in the next version :D

All packages from CSSU-devel/testing, no bb-power, kp51r1.
I have closed everything and waited I realise theme customizer finds the settings at startup.

See screenshot for no selection.
Nothing is/can be selected in 'keepcurrent-use theme' section.
Is this correct?

Lastly the next one will be 0.9.82 surely :)

ade 2013-03-09 20:45

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327964)
All packages from CSSU-devel/testing, no bb-power, kp51r1.
I have closed everything and waited I realise theme customizer finds the settings at startup.

See screenshot for no selection.
Nothing is/can be selected in 'keepcurrent-use theme' section.
Is this correct?

Lastly the next one will be 0.9.82 surely :)

Weird that "keep current wallpaper" is not selected. I defined it in Qt Creator as checked, and it does shows as selected on my device. I will set it explicitly in the code itself, no idea why it is ignored in your case.

Nothing can be selected, never could be afaik, it is just the choice between the two (or get the selected themes wallpapers, or keep your current ones). What would you expect to select?

And the loading of the settings at startup is now clarified as I understand?

sixwheeledbeast 2013-03-09 20:57

Re: [Announce / WIP] Theme Customizer
 
2 Attachment(s)
Quote:

Originally Posted by ade (Post 1327966)
Weird that "keep current wallpaper" is not selected. What would you expect to select?

And the loading of the settings at startup is now clarified as I understand?

Well I am expecting eithier use theme's wallpapers or keep current should be highlight and I should be able to change this option between them?

As you can see after modifing /usr/share/hildon-desktop/transitions.ini, closing all programs then opening theme customizer it hasn't noticed the change.
I thought this was changed in 0.9.80 so theme-customizer would find the current setting, correct?

ade 2013-03-09 21:08

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1327972)
Well I am expecting eithier use theme's wallpapers or keep current should be highlight and I should be able to change this option between them?

Ah, okay that was what I was talking about. Again this works fine on my device, but I will also explicitly set it in the code, see if that helps you.

Quote:

As you can see after modifing /usr/share/hildon-desktop/transitions.ini, closing all programs then opening theme customizer it hasn't noticed the change.
I thought this was changed in 0.9.80 so theme-customizer would find the current setting, correct?
I think it reads the values from the theme transitions.ini, just like write does. As I do not have those, it works for me.

I will look in to this, test, and report back.
Thanks for testing so far!

Edit: I see the existence of backgrounds/theme_bg.desktop makes the theme buttons disabled, that's what you are experiencing.

sixwheeledbeast 2013-03-09 23:08

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1327975)
Ah, okay that was what I was talking about. Again this works fine on my device, but I will also explicitly set it in the code, see if that helps you.

Seems I have found the issue.
Somehow theme-customizer set my selected themes "selected" option to Black so you couldn't see the selected item.
Very odd as I haven't touched the colours.

Diagnosed by switching to stock theme (blue) which worked then back to Digital nature (orange)

ade 2013-03-09 23:26

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by sixwheeledbeast (Post 1328002)
Seems I have found the issue.
Somehow theme-customizer set my selected themes "selected" option to Black so you couldn't see the selected item.
Very odd as I haven't touched the colours.

Diagnosed by switching to stock theme (blue) which worked then back to Digital nature (orange)

I already did an extra setChecked, although it is not needed reading this now :) I hope that color was not changed by theme customizer?

I looked at the buttons you mentioned. It will disable "use theme's wallpaper" if cannot find theme_bg.desktop. Which makes sense, as it stores the themes wallpaper info. So that is sorted out now.

About the transition.ini in the themes folder:
I cannot find out where it is used for, it is never put back to /usr/share/hildon-desktop/ as far as I can tell. So I removed all further references to it, and it should only deal with the current transition.ini, no relation to themes.


Code:

theme-customizer (0.9-82) stable; urgency=low
 .
  * only deal with transitions.ini in /usr/share/hildon-desktop
  * layout change color preset buttons in portrait
  * explicitly setting keep current wallpapers checked

Edit: this thead http://talk.maemo.org/showthread.php?t=57088 talks about the transition.ini files in themes. Are they used and do they have priority over the one in /usr/share/hildon-desktop/? Or is it copied during a theme installation? I never heard of that, but I could have missed something....

sixwheeledbeast 2013-03-10 09:20

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by ade (Post 1328007)
Edit: this thead http://talk.maemo.org/showthread.php?t=57088 talks about the transition.ini files in themes. Are they used and do they have priority over the one in /usr/share/hildon-desktop/? Or is it copied during a theme installation? I never heard of that, but I could have missed something....

Will try it out.

Well as you know I have looked at the sources and it was so busy it was hard to work out, for a beginner. :p

Anyway I thought I'd look at some custom themes and realised that a huge lump of theme's depend on theme-customizer :eek:

http://maemo.org/packages/package_in...omizer/0.9-77/

Looking at the sources of them they dump stuff in /usr/share/themes/foo/...
Looking at your post above they have the option of there own transitions.ini files, however there is nothing in the themes sources to indicate this.

http://maemo.org/packages/package_in...-pack-1/1.5-3/

http://maemo.org/packages/source/vie...-pack-2/1.6-5/

http://maemo.org/packages/view/plastic-icon-pack/

Hopefully this dependency issue will not be too much of a problem, the new theme packs say they work with the standard theme switcher.

visN900 2013-03-27 05:02

Re: [Announce / WIP] Theme Customizer
 
can anyone reupload the file.. links r dead..

sixwheeledbeast 2013-03-27 07:50

Re: [Announce / WIP] Theme Customizer
 
There still seems to be issues with the latest package. I guess ade is still working on it. Lasat time I tested a pre release we had issues with system text changing color when it shouldn't.

vetsin 2013-09-07 20:41

Re: [Announce / WIP] Theme Customizer
 
hi sixwheeledbeast/ade!
any news on the 0.9-82 update? :) and which among the available versions is safest to install? thanks!

ade 2013-09-08 13:58

Re: [Announce / WIP] Theme Customizer
 
Quote:

Originally Posted by vetsin (Post 1372784)
hi sixwheeledbeast/ade!
any news on the 0.9-82 update? :) and which among the available versions is safest to install? thanks!

I made some remarks about it on http://wiki.maemo.org/Community_SSU/...roken_packages about the versions. With the latest versions you should be pretty safe (even regarding transitions.ini if I remember correctly).

About an update: I did put that on hold not long after I started working on it. One of the reasons was I could not tackle a certain issue.
Maybe I will find the motivation to pick it up where I left it. But as they say: don't hold your breath.

sixwheeledbeast 2013-09-08 14:46

Re: [Announce / WIP] Theme Customizer
 
Yes, sorry I missed this.
Theme-customizer is a bit of a mess really (as you can see above), however, the latest ade version is "pretty safe". I think there was some issue with some theme colours not saving, but I can't remember.

The main issue of theme-customizer installing a obsolete version of h-d is repaired anyway.

I thank ade for looking into it, but it really isn't the nicest program to takeover maintenance of. So I understand "don't hold your breath".

jmo707 2015-02-15 12:47

Re: [Announce / WIP] Theme Customizer
 
Hi Ade,

could you please re-upload version 0.9.81 deb?

Thanks!

d-iivil 2017-10-12 20:35

Re: [Announce / WIP] Theme Customizer
 
Holy crap! After few years I found myself reading this thread :) Oh good old days. I would give anything to get a phone like N900 with current CPU power out there :)


All times are GMT. The time now is 13:50.

vBulletin® Version 3.8.8