maemo.org - Talk - [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Is anyone interested in adopting and maintaining the great patch named No home carousel? Unfortunately, Cornerman is not using Sailfish anymore and he is looking for a maintainer: https://github.com/cornerman/sailfis...ment-403765302

This patch greatly improved (in my opinion) the user experience by restoring the "one swipe direction = one feature" spirit of early Sailfish versions before everything was made less consistent to conform with the introduction of partnerspace. It also improved the task switcher page by allowing quick close gestures on covers, and allowed swiping events in the Events page to remove them without changing page.

The comments on OpenRepos show how much this patch was appreciated, as it had a great impact on whole UI.

kneeli

2018-07-10 10:32

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by coderus (Post 1546112)

in the past email did not provide qml files, nowadays you can patch it. no need to mess systemwide plugins. please.

Ok. you are right.

@Markkyboy
Please discharge all changes made on file /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

Instead insert in file /usr/share/jolla-email/pages/HtmlViewer.qml
at around line 24 the following:

experimental.transparentBackground: true

that's enough, I tried it already.

kneeli

2018-07-10 11:22

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by Markkyboy (Post 1546113)

Kneeli - your code shown for HtmlViewer.qml does not match what I have. I'm on SFOS 2.2.0.29 - which version are you using?

is in function

Code:

function setHtml(html) {

}

The sailfish mail app, does show many html mails in desktop view. Sometimes there even not zoom able, so unreadable at all.

In this function jolla-email does count the viewport, which seems to be buggy sincs version 1

I just defined a fix viewport with 300, which make nearly all html emails readable and shows them up in mobile view if there responsive.

Just replace this function with:

Code:

    function setHtml(html) {

        htmlBody = html

            experimental.customLayoutWidth = 300

        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")

        onScreen = true

    }

Markkyboy

2018-07-10 18:30

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Man, did I get in a muddle!, 35c here, fitting a new bathroom and compiling this patch, I am cooked!!

Anyway, I can now see the new changes that have been made, text looks a little too big in HTML emails, but is now very readable and plain emails also are now easily readable, see what you guys think!

As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1;

https://www.dropbox.com/s/d66q7kojnc...oarch.rpm?dl=0

kneeli

2018-07-10 20:33

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by Markkyboy (Post 1546129)

text looks a little too big in HTML emails

Here on my device, sometimes too big, mostly perfect. I have the XperiaX, I don't know how does it look an screens with more less resolution.
But anyhow, sometimes too big is far better as sometimes too tiny and not zoomable.

I just looked an you're patch, it seems all parts to be fine.

You're CSS file is well formatted. I changed mine, with you're version.

kneeli

2018-07-10 20:43

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by Markkyboy (Post 1546129)

As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1

ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:

Code:

loadHtml(htmlBody, "file:///usr/share/jolla-email")

But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.

Markkyboy

2018-07-10 21:17

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by kneeli (Post 1546136)

ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:

Code:

loadHtml(htmlBody, "file:///usr/share/jolla-email")

But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.

Cool, yeah, I've just tried 480, for me it's a little too small, so I set at 400 instead, which looks pretty good on my Jolla1. Also line 98 changed to your specification.

Thanks for the code! :)

PATCH VERSION THREE:

https://www.dropbox.com/s/f5xbhgjczl...oarch.rpm?dl=0

I think this is ready to be offered on Openrepos

Markkyboy

2018-07-11 10:49

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager

coderus

2018-07-11 14:29

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by Markkyboy (Post 1546155)

@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager

this readme is outdated... check pm2 submit page

Markkyboy

2018-07-11 15:43

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak

Quote:

Originally Posted by coderus (Post 1546160)

this readme is outdated... check pm2 submit page

and where might that be?, link please.

All times are GMT. The time now is 12:05.

Page 256 of 291

« First

< Prev