maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   [M5] [Announce] Yappari - New maintainership and new features! (https://talk.maemo.org/showthread.php?t=94465)

Faso_II 2015-03-06 08:39

Re: [Announce] Yappari - New maintainership and new features!
 
My Yappari is working fine...
One thing: now people that I don't know in new groups are displayed with their telephone number, while in the past I could see their nickname.
Is this a common issue?

ceene 2015-03-06 08:49

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by Faso_II (Post 1463208)
My Yappari is working fine...
One thing: now people that I don't know in new groups are displayed with their telephone number, while in the past I could see their nickname.
Is this a common issue?

It seems to be, but no one has ever sent me a log to help me debug this issue...

guidofasano 2015-03-06 15:09

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463210)
It seems to be, but no one has ever sent me a log to help me debug this issue...

Yo aun presento el mismo problema, que al conectarse se cierra automaticamente yappari. ayer te volvi a enviar el nuevo registro de error por correo, espero puedas resolver, gracias por tu tiempo.

ceene 2015-03-06 16:09

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by guidofasano (Post 1463253)
Yo aun presento el mismo problema, que al conectarse se cierra automaticamente yappari. ayer te volvi a enviar el nuevo registro de error por correo, espero puedas resolver, gracias por tu tiempo.

Muchas gracias. Con suerte, si el trabajo me lo permite, durante el fin de semana podré avanzar con tu problema.

keerty 2015-03-06 18:13

Re: [Announce] Yappari - New maintainership and new features!
 
Thanks to all who have been supporting the application for so long! Its a big help !
my yappari is unable to register for the last 10 hours, its the same issue faces earlier in january. any fixes anyone is aware of ?

NerdKnight 2015-03-07 01:13

Re: [Announce] Yappari - New maintainership and new features!
 
1 Attachment(s)
I've compiled Yappari 2.0.8 with debugging symbols and this is the backtrace when it crash with segfault:
Code:

#0  0x414f03d2 in QIODevice::isOpen() const () from /usr/lib/libQtCore.so.4
#1  0x00071908 in BinTreeNodeReader::getOneToplevelStream (this=0x8400e8)
    at Whatsapp/bintreenodereader.cpp:58
#2  0x000719cc in BinTreeNodeReader::nextTree (this=0x8400e8, node=...)
    at Whatsapp/bintreenodereader.cpp:142
#3  0x0004ec50 in Connection::read (this=0xea4060)
    at Whatsapp/connection.cpp:142
#4  0x00076e54 in Client::read (this=0x3f82e0) at client.cpp:1132
#5  0x0013d760 in Client::qt_metacall (this=0x3f82e0,
    _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0xbe880f80)
    at moc_client.cpp:193

I made some validations to the code, attached a patch, I will continue debugging and let you know if I find something else.

coderus 2015-03-07 01:49

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by NerdKnight (Post 1463301)
I've compiled Yappari 2.0.8 with debugging symbols and this is the backtrace when it crash with segfault:
Code:

#0  0x414f03d2 in QIODevice::isOpen() const () from /usr/lib/libQtCore.so.4
#1  0x00071908 in BinTreeNodeReader::getOneToplevelStream (this=0x8400e8)
    at Whatsapp/bintreenodereader.cpp:58
#2  0x000719cc in BinTreeNodeReader::nextTree (this=0x8400e8, node=...)
    at Whatsapp/bintreenodereader.cpp:142
#3  0x0004ec50 in Connection::read (this=0xea4060)
    at Whatsapp/connection.cpp:142
#4  0x00076e54 in Client::read (this=0x3f82e0) at client.cpp:1132
#5  0x0013d760 in Client::qt_metacall (this=0x3f82e0,
    _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0xbe880f80)
    at moc_client.cpp:193

I made some validations to the code, attached a patch, I will continue debugging and let you know if I find something else.

This is not socket isOpen, this is QBuffer one here: https://github.com/agamez/yappari/bl...reader.cpp#L58

ceene 2015-03-07 11:29

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by coderus (Post 1463302)
This is not socket isOpen, this is QBuffer one here: https://github.com/agamez/yappari/bl...reader.cpp#L58

How is it possible for isOpen to segfault? I'm struggling to understand the reason.

freemangordon 2015-03-07 13:57

Re: [Announce] Yappari - New maintainership and new features!
 
Quote:

Originally Posted by ceene (Post 1463318)
How is it possible for isOpen to segfault? I'm struggling to understand the reason.

If the object you're calling isOpen on (i.e. this pointer) is invalid ;)

NerdKnight 2015-03-07 17:19

Re: [Announce] Yappari - New maintainership and new features!
 
Maybe closing the QBuffer at the end of nextTree method instead at the beginning could do the trick, I'll test it.
Code:

diff --git a/src/yappari-application/Whatsapp/bintreenodereader.cpp b/src/yappari-application/Whatsapp/bintreenodereader.cpp
index 6d32774..59b42c5 100644
--- a/src/yappari-application/Whatsapp/bintreenodereader.cpp
+++ b/src/yappari-application/Whatsapp/bintreenodereader.cpp
@@ -146,6 +146,9 @@ bool BinTreeNodeReader::nextTree(ProtocolTreeNode& node)
    node.setSize(getOneToplevelStreamSize());
 
    result = nextTreeInternal(node);
+    if (decodedStream.isOpen()) {
+        decodedStream.close();
+    }
    Utilities::logData("INCOMING:\n" + node.toString());
    return result;
 }



All times are GMT. The time now is 21:49.

vBulletin® Version 3.8.8