maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   SailfishOS (https://talk.maemo.org/forumdisplay.php?f=52)
-   -   No notification when new voicemail ? Here come the patch ! (https://talk.maemo.org/showthread.php?t=94498)

Zeta 2015-01-20 21:46

No notification when new voicemail ? Here come the patch !
 
2 Attachment(s)
Update:
Patch is uploaded on openrepos:
https://openrepos.net/content/zeta/p...l-notification

You can now download it directly from warehouse (search for "voicemail") and apply it with patch-manager !


Detailed description

For people having the "No notification when new voicemail" problem, and who don't have an SMS as a fallback, here is a patch that works for me (France, B&You operator).

You can find all details of the bug here : https://together.jolla.com/question/...#post-id-76513

Finally, the patch to show a voicemail icon on the lockscreen is below.

I am quite new to QML and really new to Ofono, so this may not be the best way to do it, for it seems to work for me after some tests.

Code:

--- /usr/share/lipstick-jolla-home-qt5/lockscreen/Lockscreen.qml.orig        2015-01-20 20:55:32.224928108 +0100
+++ /usr/share/lipstick-jolla-home-qt5/lockscreen/Lockscreen.qml        2015-01-20 22:22:28.496361601 +0100
@@ -12,6 +12,7 @@
 import org.nemomobile.time 1.0
 import "../notifications"
 import "../scripts/desktop.js" as Desktop
+import MeeGo.QOfono 0.2
 
 MouseArea {
    id: lockScreen
@@ -254,6 +255,20 @@
        anchors.bottom: clock.top
    }
 
+    OfonoManager { id: ofonoManager }
+
+    OfonoMessageWaiting {
+        id: ofonoMessageWaiting
+        modemPath: ofonoManager.modems.length > 0 ? ofonoManager.modems[0] : ""
+    }
+
+    Image {
+        anchors.bottom: clock.top
+        source: "/usr/share/themes/jolla-ambient/meegotouch/icons/icon-s-voicemail.png"
+        visible: ofonoMessageWaiting.voicemailWaiting
+    }
+
+
    SneakPeekHint {
        id: sneakPeekHint
    }

After applying this patch (take care, it can break things, so keep an SSH session opened and a backup of the file!), you'll need to restart lipstick to be used : devel-su systemctl-user restart lipstick.service

Attached is an image of what it currently looks like (screenshot taken while in low power mode, but it is also shown when unlocked). The icon doesn't follow the ambiance theme, I think this is due to using a full path and not the "image://theme/xxx" as I have seen somewhere else, but it found the image that way.

First image is using file icon-lock-voicemail.png, second one is using icon-s-voicemail.png which looks more like sailfish UI but is less visible (the way I displayed it, could be improved by a UI guru). Don't take care of the 2 new mails in the second image, the voicemail is the small one at the bottom left...

Next step is to look how to make a patch for patch-manager, and submit it to warehouse for it to be available to everyone.

If someone want to help me on this (publishing the patch, correcting problems in that QML, or making it look beautiful), I would be glad.

coderus 2015-01-20 22:39

Re: No notification when new voicemail ? Here come the patch !
 
Very good hack/fix imho. Need help in building rpm with patch for patchmanager?

Zeta 2015-01-20 23:17

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1457430)
Very good hack/fix imho.

Thanks ! :o
Quote:

Originally Posted by coderus (Post 1457430)
Need help in building rpm with patch for patchmanager?

Yes.
I have not yet started to read documentation on how it works.

I don't know how much time is needed to create such a patch. Do you have some pointers to forum thread to read, howtos or examples ?

Also I will need to see how to put them in warehouse when done. Here also, any link or doc explaining the process would be of great use.

Thanks !

coderus 2015-01-20 23:25

Re: No notification when new voicemail ? Here come the patch !
 
Not too much. It's about 5 minutes.

https://dl.dropboxusercontent.com/u/...1-1.noarch.rpm

Zeta 2015-01-20 23:29

Re: No notification when new voicemail ? Here come the patch !
 
2 Attachment(s)
Following a tip from r0kk3rz, I made a test with this code (standalone, not connected to ofono), and it provides notifications on the lockscreen and in the events view as is already done for SMS and mails.
So no need to say it looks a lot better than what I did.

Code:

            Button {
                Notification {
                    id: notification
                    category: "x-nemo.messaging.voicemail"
                    summary: "Notification summary"
                    body: "Notification body"
                    previewSummary: "Notification preview summary"
                    previewBody: "Notification preview body"
                    itemCount: 5
                    timestamp: "2013-02-20 18:21:00"
                }
                text: "Application notification, ID " + notification.replacesId
                onClicked: {notification.publish(); }
            }

The trick is the : category: "x-nemo.messaging.voicemail" which triggers some specific icons and display logic.

Questions are where should this be put (it is ugly to put it in the lockscreen code if it is not anymore related to graphical stuff, but only to connect ofono to notification mechanism) ?

And how to keep it there until the message is really read (not simply clicked) ?
There is "x-nemo-user-removable=true" in the https://github.com/nemomobile/nemo-q...tification.cpp documentation, which can be the solution.
Then the notification index return when creating it should only be kept to later delete it when ofono says all messages have been read.

And the number of message here set to 5 for the test, will obviously not be shown for people where it is not availlable, but on operators where it is provided there is not reason not to use it.

Zeta 2015-01-20 23:32

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1457432)
Not too much. It's about 5 minutes.

https://dl.dropboxusercontent.com/u/...1-1.noarch.rpm

It is too late for today, I should already be sleeping...
Will take a look at it tomorrow if possible.

Thanks !

romu 2015-01-21 07:29

Re: No notification when new voicemail ? Here come the patch !
 
Excellent Zeta ! Can't wait the rpm...

This makes a lot of patches Jolla should integrate into Sailfish !

EDIT: stupido I'm, thanks @coderus. :D

mousse04 2015-01-22 10:46

Re: No notification when new voicemail ? Here come the patch !
 
Finally :). Thanks a lot Zeta ;)

meldolion 2015-01-22 14:54

Re: No notification when new voicemail ? Here come the patch !
 
How do you get the preferences shortcuts on your notification screen?

coderus 2015-01-22 17:21

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by meldolion (Post 1457586)
How do you get the preferences shortcuts on your notification screen?

this way: https://openrepos.net/content/coderu...ettings-applet

abyzthomas 2015-01-22 18:45

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1457603)

After applying the patch, I get a text message like this:

//VVM:SYNC:ev=NM;id=416;c=1;t=v;s=1#########;dt=22/01/2015 12:39 -0600;l=7

I dont see the icon on lock screen either.

T-Mobile USA.

Any idea why?

Update 1: Replaced my phone number with ######## :o

Update 2: Actually, after a reboot, the VM icon shows up. I still get the SMS, but the icon also shows up.

Once I delete the VM, the icon gets removed correctly and I receive the following text message:

//VVM:SYNC:ev=MBU

Great Job!!! Thank you very much Zeta.

coderus 2015-01-22 19:05

Re: No notification when new voicemail ? Here come the patch !
 
@abyzthomas patch does nothing with sms, and your sms problem is not relevant to patch

abyzthomas 2015-01-22 19:57

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1457610)
@abyzthomas patch does nothing with sms, and your sms problem is not relevant to patch

Sorry, I didn't mean that it is the patch that is doing that. Before the patch, I was not getting any notification when leaving a voicemail.

I had been using GoogleVoice as my voicemail because it can send a text message when someone leaves a VM.

Today, I enabled the patch and changed my forwarding setting to the T-Mobile VM number. When I left a test VM, I got the above text message right away, but no icon. After I posted the message, I thought maybe I will try rebooting.

After the reboot, I get the text messages in addition to the notification icon on lock screen. I left VM and deleted few times, and behavior was same. It successfully enables the icon and removes it when deleting the VM. Works Great!!!

I am so happy you guys have done this patch and thank you to you too coderus. This was a must have feature for a phone.

This text message is no problem for me, I can ignore it.

I posted the text messages just in case, it helps you guys to figure out something.

One suggestion I have is that if possible, move the icon below the network traffic/wifi icon. This allows it to be visible from anywhere on the peeking screen.

abyzthomas 2015-01-22 20:06

Re: No notification when new voicemail ? Here come the patch !
 
Hmmm... Just realized (from googling) //VMM stands for Visual Voice Mail. I probably have that on my account, though I have never used it. I will have T-Mobile disable it and test it.

Well then, the good news is, the patch works great in US T-Mobile network also.

mousse04 2015-01-22 20:09

Re: No notification when new voicemail ? Here come the patch !
 
On orange France, I got text message but no voice mail icon. Maybe my orange account is not well set up

Zeta 2015-01-22 23:06

Re: No notification when new voicemail ? Here come the patch !
 
Great news:

Thanks to coderus, r0kk3rz, kimmoli and other guys on IRC, I managed to create the patch for patch manager on github:
https://github.com/Sagittarii/sailfi...oicemail-patch

Compile it in OBS:
https://build.merproject.org/package...oicemail-patch

And upload it on openrepos:
https://openrepos.net/content/zeta/p...l-notification


So that you can now download it directly from warehouse and apply it with patch-manager ! :cool:

I am updating the front page to have the link directly there.

Big thanks for all the people who helped me putting it together.

Zeta 2015-01-22 23:11

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by mousse04 (Post 1457618)
On orange France, I got text message but no voice mail icon. Maybe my orange account is not well set up

Did you restart lipstick after applying the patch ?
If not, then it is normal to not see anything.

Now you can apply it from patch-manager which have a pulley-menu to "restart services" after applying the patch that will ensure it is really used.

Otherwise, don't hesitate to ping me in #sailfishos or #JollaFr IRC, or here.

Schturman 2015-01-22 23:48

Re: No notification when new voicemail ? Here come the patch !
 
2 Attachment(s)
Zeta, big thanks for this patch!
I changed icon, looks better (I think at least :D ). Work perfectly with 012 Mobile and Orange (Israel).
Later I will create package for NON patchmanager users..

coderus 2015-01-23 00:31

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by Schturman (Post 1457654)
Later I will create package for NON patchmanager users..

NOOO please don't do it again D:

Schturman 2015-01-23 00:36

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1457660)
NOOO please don't do it again D:

Haaa, no problem , for you, what you want.

coderus 2015-01-23 00:47

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by Schturman (Post 1457661)
Haaa, no problem , for you, what you want.

No, really, why you doing it?

Thaodan 2015-01-23 03:50

Re: No notification when new voicemail ? Here come the patch !
 
Do I need to disable the SMS fallback manually?

abyzthomas 2015-01-23 04:08

Re: No notification when new voicemail ? Here come the patch !
 
1 Attachment(s)
Quote:

Originally Posted by Zeta (Post 1457648)
Great news:

And upload it on openrepos:
https://openrepos.net/content/zeta/p...l-notification

I made a small change to your Lockscreen.qml. I moved the Voicemail icon below the Bluetooth icon. This allows it to be visible from the lock screen as well as the peek view.

If anyone interested, here is the chenge:

Code:


    OfonoManager { id: ofonoManager }

    OfonoMessageWaiting {
        id: ofonoMessageWaiting
        modemPath: ofonoManager.modems.length > 0 ? ofonoManager.modems[0] : ""
    }

    Image {

//        Commented out the following line
//        anchors.bottom: clock.top

//      Added the following
        anchors {
            bottom: clock.verticalCenter
            bottomMargin: -90
            left: parent.left
            leftMargin: Theme.smallIcons ? Theme.paddingSmall : Theme.paddingLarge
        }

        source: "/usr/share/themes/jolla-ambient/meegotouch/icons/icon-s-voicemail.png"
        visible: ofonoMessageWaiting.voicemailWaiting
    }

See the screen shot.
Attachment 36438

romu 2015-01-23 09:06

Re: No notification when new voicemail ? Here come the patch !
 
Tested yerterday, works really great. Just some comments about the visual: the icon (didn't change anything in the patch) is too much on the left. I would be great of the icon could be aligned as the other notifications icons. I also have the feeling the icon is too much on the bottom and should be closer to the top of the screen.

Just a personal feeling anyway. Thanks a lot Zeta!

ced117 2015-01-24 21:53

Re: No notification when new voicemail ? Here come the patch !
 
Again, thank you for this patch Zeta !
Excellent work.

bluefoot 2015-01-26 02:55

Re: No notification when new voicemail ? Here come the patch !
 
Great work, Zeta. Finally the Jolla is almost on par with 15 year old feature phones in terms of basic phone functionality. Hopefully they will roll this into update 11.

On the other hand, Jolla should be ****ing ashamed of themselves. A patch this small? I bet the bastards never even looked at the issue, let alone assessing how much work it would take, after promising over a year ago that it was on the "to do list".

juiceme 2015-01-26 05:44

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by bluefoot (Post 1458183)
Great work, Zeta. Finally the Jolla is almost on par with 15 year old feature phones in terms of basic phone functionality. Hopefully they will roll this into update 11.

On the other hand, Jolla should be ****ing ashamed of themselves. A patch this small? I bet the bastards never even looked at the issue, let alone assessing how much work it would take, after promising over a year ago that it was on the "to do list".

Some need it, some not.
I don't even know what is voicemail, and how to send/receive one if I needed to.

coderus 2015-01-26 06:02

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by juiceme (Post 1458192)
Some need it, some not.
I don't even know what is voicemail, and how to send/receive one if I needed to.

It's just an option of your operator. If someone not available or dont' want to answer your call is redirected to voicemail and you hear "blah-blah, your message will be recorded after beeep". And after you end your message recipient received voicemail notification and/or sms message about X unread voicemails :)

juiceme 2015-01-26 06:23

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by coderus (Post 1458194)
It's just an option of your operator. If someone not available or dont' want to answer your call is redirected to voicemail and you hear "blah-blah, your message will be recorded after beeep". And after you end your message recipient received voicemail notification and/or sms message about X unread voicemails :)

Ah, yes, now I know that, we call it "answering machine" in finland.
(there used to be separate machines which performed this thing when people still used traditional wired telephones. The things worked with c-casettes, playing a pre-recorded message and recording your answer.)

And yes, I don't like that and when I dial somebody and get forwarded to that service, I always hang up.

pichlo 2015-01-26 09:38

Re: No notification when new voicemail ? Here come the patch !
 
It's not just you calling someone else. When I was job hunting, the agencies kept leaving me voicemail all the time. Sadly, the N900 is just as bad as Jolla in this respect and also does not have a voicemail indicator.

Zeta 2015-01-26 23:45

Re: No notification when new voicemail ? Here come the patch !
 
Yes, that is part of the basic functionality of the mobiles phones since several years.
It is especially useful for mobile phones, as we don't always have the network (in subway, in old buildings with thick walls, in countryside/mountain). In those cases, you don't have a notification of missed call. But the guy could have left a message, something that can be important and you won't miss (job, flat...).
Your friends calling from mobile phone can leave you an SMS or reach you through some other service, but when a company wants to hire you calling from a landline phone (no sms!), and need to talk with you as soon as possible, you are thankful when the phone tells you they called and left a voicemail when going out of the subway !

Jolla didn't answer any of my message with details, except than "We'll check and update TJC if there's any ETA. Thanks for the ping". I hoped they would have answered when I found this patch with something more meaningful about why they cannot do it like this, or that they have added this to some future update. Anything.

I know that this is not the only bug in their list, but it is a part of the basic phone functionality (as in "Nokia 3310 had it"...) and a lot of people complained about it for missing messages and having to call it randomly to check (talk about "smart"...phone) so it is strange they don't react about this.

Jolla, if you read me, let me know how we can help on this ! You ask us to do it together, we are ready... :(

In the mean time, thanks to the help from the community (patch-manager, ideas and tips on IRC, tests on other operators...) at least we have something that works. :)

P@t 2015-01-27 09:35

Re: No notification when new voicemail ? Here come the patch !
 
The only thing I can think for not having Jolla to work on that (easy?) fix is that they probably need to make some field tests and see if it really works on all supported countries with all network providers. It may work differently in some case?!
anyway thanks for that :)

pichlo 2015-01-27 10:25

Re: No notification when new voicemail ? Here come the patch !
 
I think the real reason is as Zeta said. They have not even looked at that. So they never even got to the point of assessing whether it is a 5 minutes fix or a 5 months one.

Now, I do not blame them for that. They have a lot on their plate and they have to prioritize. Not knowing how difficult the fix is, I would also prefer them focusing on more burning issues such as the forced random app closing.

However, there is a big twist in the tale. Zeta has investigated the issue and provided a solution. That suddenly changes the game. It is no longer a case of "5 minutes or 5 months, we don't know". The task complexity has become known. I am not suggesting that they should drop everything and do this right now, but I agree with Zeta: the lack of any sensible response is unacceptable.

I work for a small software company. I could not imagine the PR disaster if one of our customers found a solution to a problem that has been on our backlog for a year and we would not even say thank you, we will test it and include it in our next release. And by the way, here is a bunch of flowers for your wife as an expression of our gratitude.

nodevel 2015-01-27 12:26

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by Zeta (Post 1458356)
It is especially useful for mobile phones, as we don't always have the network (in subway, in old buildings with thick walls, in countryside/mountain). In those cases, you don't have a notification of missed call.

Yes you do. At least all service providers I've ever used would send me an SMS once I was back online, saying "You have a missed call from XXX-XXX-XXX from 27.01. 2015 13:25. Please, call them back. Have a nice day.". And what's better, the service provider makes it seem like it was sent by the other person (will appear under their name), so calling/texting them is just a step away.

That is the reason why I don't use voicemail and also why I hate when the person I'm calling does have it.
If I am unavailable, why should the other party pay for it? It is my problem, so I call back once I'm back online.

I'm not saying people shouldn't use it (I wish they wouldn't, though), but I don't see the use in my case.

peterleinchen 2015-01-27 15:14

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by Zeta (Post 1458356)
...

Jolla didn't answer any of my message with details, except than "We'll check and update TJC if there's any ETA. Thanks for the ping". I hoped they would have answered when I found this patch with something more meaningful about why they cannot do it like this, or that they have added this to some future update. Anything.

I know that this is not the only bug in their list, but it is a part of the basic phone functionality (as in "Nokia 3310 had it"...) and a lot of people complained about it for missing messages and having to call it randomly to check (talk about "smart"...phone) so it is strange they don't react about this.

Jolla, if you read me, let me know how we can help on this ! You ask us to do it together, we are ready... :(

...

Just as a side note, even you mentioned TJC,:
Jolla did/does not see TMO as the platform to discuss/publish such information.
But WE do ...

pichlo 2015-01-27 16:21

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by nodevel (Post 1458393)
At least all service providers I've ever used would send me an SMS once I was back online, saying "You have a missed call from XXX-XXX-XXX from 27.01. 2015 13:25. Please, call them back. Have a nice day.".

You are lucky ;)

I have seen four different cases, and that is only in my limited experience with the provides I have used personally:
1) You missed a call for whatever reason. The other party left a message. Outcome: the voicemail indicator lights up.
2) You missed a call because you did not hear the phone ringing or rejected the call. The other party did not leave a message. Outcome: nothing, only a missed call indicator on your phone.
3) You missed a call because you were out of range. The other party did not leave a message. Outcome: a friendly SMS from the operator along the lines you mention above.
4) 3) You missed a call because you were out of range. The other party did not leave a message. Outcome: nothing at all. You never know you missed a call.

Please note that in none of the four cases did the operator send me an SMS when the other party has left a message. Cases 3 and 4 depend on the operator. Only one of the four operators I used personally does #3.

bluefoot 2015-01-27 19:14

Re: No notification when new voicemail ? Here come the patch !
 
I think this bodes terribly for Jolla and the development of Sailfish generally. It gives a glimpse into how haphazard, lackadaisical or generally disorganised or directionless Jolla are, and is completely consistent with much of the rest of their activity (or lack thereof).

The near 6 months between stable updates, because they thought it would be a good idea to implement a new version of Qt without any infrastructure in place to roll things back or forward, or branch development, suggests pretty staggering naivety.

Their communication is generally extremely poor. Only now, 14 months after launch, are we beginning to get very vague 'roadmap' type statements.

Various simple things don't get fixed or hotfixed. Some of them which are allowed to go for months and months. One suspects the reason is "can't be bothered" more than anything.

The most amazing thing to me is that all we know about paid for apps is in April last year they were aiming for an H2 launch, and in early December it was a "priority" but being held up by "technical issues". Clearly they missed their extremely vague H2 window, and what technical issues exactly? There are numerous off the shelf solutions that they could probably implement within days. Are we to believe that they're flailing around trying to code their own secure payments system from the ground up? If so, why? If so, why are they not implementing an off the shelf product as an interim solution? Sailfish has lost enough developers already, none of which it could afford to lose, and given both the tiny size of the ecosystem and the total lack of incentive to develop for it, how will it ever become self sufficient? What if Warehouse / OpenRepos hadn't taken off? Sailfish would be completely dead.

It seems like Jolla have yet to contact Zeta about this. It's pretty saddening and makes it extremely hard to have any optimism about the way the company is run.

Zeta 2015-01-27 19:20

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by nodevel (Post 1458393)
Yes you do. At least all service providers I've ever used would send me an SMS once I was back online, saying "You have a missed call from XXX-XXX-XXX from 27.01. 2015 13:25. Please, call them back. Have a nice day.". And what's better, the service provider makes it seem like it was sent by the other person (will appear under their name), so calling/texting them is just a step away.

That is the reason why I don't use voicemail and also why I hate when the person I'm calling does have it.
If I am unavailable, why should the other party pay for it? It is my problem, so I call back once I'm back online.

I'm not saying people shouldn't use it (I wish they wouldn't, though), but I don't see the use in my case.

You missed completely the problem here.

My phone provider sends those messages (just checked with another SIM card from them in my Android phone).

My Jolla phone doesn't display them !!!!!
This SIM card was previously in my N8 which displayed them correctly (both missed calls and voicemails when you come back in the network).

So then 2 problems can arise:
* someone called and didn't leave a message. I will never know it, but if it was important they would have left a message.
* someone called and left a message. That was surely important ! Jolla doesn't display it, so here comes this patch that at least says "you should check your voicemail, there is something here, but I don't know from who".

bluefoot 2015-01-27 19:27

Re: No notification when new voicemail ? Here come the patch !
 
@Zeta

There's also the issue that with a lot of networks that do provide SMS notification still (some don't), you have to manually enable it from your account with them (O2 are a major example). So if you're abroad or using an unfamilar or new network / SIM card, you may either not realise you have to enable it or are prevented from doing so due to language barrier.

The fact there's no warning about lack of enhanced notification and the bugs / need to provider enable sms notifications in the phone's settings is awful.

The message is clearly that Jolla would rather people suffer inconvenience and miss potentially important voicemails than either acknowledging or fixing the problem.

Zeta 2015-01-27 19:36

Re: No notification when new voicemail ? Here come the patch !
 
Quote:

Originally Posted by peterleinchen (Post 1458415)
Just as a side note, even you mentioned TJC,:
Jolla did/does not see TMO as the platform to discuss/publish such information.
But WE do ...

I know. That's why there is a one year running TJC thread, plus several pings on Twitter.
This sentence from me there directed to Jolla was only dictated by despair ;)


All times are GMT. The time now is 00:37.

vBulletin® Version 3.8.8