View Single Post
Posts: 191 | Thanked: 415 times | Joined on Jan 2012
#306
Originally Posted by int_ua View Post
Nice patch I have one question and two requests.
What's the benefit of having dynamic root partition number?
From the functional POV I think none, although it makes things more flexible. This was a by-product of using sfdisk instead of fdisk.

Can you please make patches against the unstable branch? Currently I'm adding parts of your patch so wait until revision 128. Also, I'm going to change the URL for unstable branch right now, will update this post and the first one in the thread with it.
Sure. I will wait for 128 and take a look.

And the last one: AFAICS the dynamic root partition number doesn't work yet because of unchanged install-chroot-part.sh
Yesterday I ran the installation to the end using only 2 partitions (vfat and ext4 root), and I booted the system fine last night with root at p2. I will double-check this point.
 

The Following 4 Users Say Thank You to caveman For This Useful Post: