View Single Post
Posts: 2,225 | Thanked: 3,822 times | Joined on Jun 2010 @ Florida
#511
So I come to this thread to figure out why the kernel update is conflicting with the injection drivers package - only to see that daaaaamn things have progressed. Reinob's talking about actually possibly getting rid of BME as a practical possibility (one he's actually been doing right now). So reinob, you're extra-awesome.

To maintainers of this kernel, and anyone else involved in the making of the new modules and all the updates, you're awesome.

I do wish the changelog was included in the actual debian packaging, so when I'm installing the package through the package managers I can read these changes. I also wish it was stated immediately where the 'included-in-kernel-power-modules' injection drivers are located (like, I fail to see why pali didn't think to include that info in this post: http://talk.maemo.org/showpost.php?p...&postcount=445 - I figured it out by 'dpkg -L kernel-power-modules', but still). But those are minor grievances, and I am glad to see kernel-power-modules actually include the injection drivers now. On the other hand, my anal give-users-choices philosophy is kicking in and kinda wanting to argue that it would be better of users could choose to not have the drivers there unless they wanted them, but at the same time, I know the drivers are in /opt and the amount of space they take up is small anyway, so it's probably not a big deal to the vast majority of users. It's probably better for package maintenance logistics to have these modules in the kernel (power) modules package anyway.

- About replacing BME and the ACT-DEAD state -
I personally support leaving it in somewhere, and maybe introducing some way of checking/setting user preferences as to whether they want stock act-dead, framebuffer console, or normal boot (I think it's fine if this was in some obscure config file - others will code GUIs for editing these things if they wanted). I think you could accomplish this fairly easily with a shell script (/ addition to /sbin/preinit ) that, if state is ACT-DEAD, loads the minimum required drivers to power off the screen completely, unloads fbcon and dependencies if they're loaded, execute whatever the kernel-charging voodoo is needed, then upon detecting full charge, run 'shutdown', and there's your act-dead. Well, I guess normal act-dead leaves green LED on instead of shutting down, so do that instead, and add a 'shutdown after charge on act-dead' option for the shutddown version.

I would also argue for not worrying about console shell for those options because in my opinion the ideal boot console prompt would come in a single spot that all boot paths would go through - I personally like having my absurdly-early /sbin/preinit press-any-key-for-shell spot, which kicks in before it even checks the bootstate if I recall correctly, but for most users something later (when things are actually mounted) would be nicer.
 

The Following 4 Users Say Thank You to Mentalist Traceur For This Useful Post: