View Single Post
Posts: 49 | Thanked: 103 times | Joined on Apr 2010
#49
Originally Posted by nodevel View Post
Thank you, that's wonderful!

I am using Quickddit on Jolla (not N9) but I have recently done some changes just for my own use (like workaround for .gifv animations) and wanted to make a pull request, but I was also quite disappointed that dicksonleong does not accept them anymore (leaves them open).

So if I want to contribute, can I make a pull request on your fork?
You can, if you go to my fork on github. But I already have gifv support implemented in my 'preview' feature branch, based on patches submitted by Martin Sandsmark. It is already working quite nicely and I hope to include it in the next release, but there's still some minor issues with UI feedback on 404 etc.

Originally Posted by nodevel View Post
I hope dicksonleong is fine with someone else continuing with his effort.
We talked, he's fine with it. I cannot however post updates to openrepos under his account, so it might be confusing for people to see multiple Quickddits there

Originally Posted by nodevel View Post
EDIT:
Some things I have been thinking of (but can't promise I'll have enough time to implement them) were:
- Reddit Live support (initial proof of concept done, but waiting for Qt upgrade to bring official support for SOAP)
- gifv implementation/workaround (the workaround is quite simple)
- user profiles
- video support either through youtube-dl, or through opening links in LL's video player.
Patches/pull requests are very welcome! I do want to keep the app as close as possible to Sailfish UX guidelines though, I think I'm on the same page as Dickson here..
 

The Following User Says Thank You to accumulator For This Useful Post: