View Single Post
olf's Avatar
Posts: 305 | Thanked: 1,246 times | Joined on Aug 2015
#2224
Continuing
Originally Posted by olf View Post
# 2208
(i.e. still the same setup):

5. Bug when applying multiple Patches in a row
Short description:
When applying multiple Patches one after the other, freshly enabled Patches are displayed as unapplied after a little while.
Steps to reproduce:
a. Install multiple new Patches (tested with 3 to 6). It does not matter, if from the Web catalog or via RPM (e.g. Warehouse).
b. Enable them one right after the other. Timing does not matter.
c. For each Patch, the cycle is:
- When hitting the button, it lights up (O.K.)
- A notification about installing this Patch is displayed (O.K.).
- After applying the next Patch and waiting for a little while, the button is unlit, again (not O.K.).
So finally it looks like only the last one of the freshly installed Patches is actually applied.
d. Exiting Patchmanager 2.0 and entering it again then correctly shows, which Patches are applied (and which are not).
Expected behaviour:
Buttons indicating an applied Patch stay lit, after applying multiple Patches in a row.

*Edit:* This seems the happen on every multiple "apply" / "unapply" actions in a row: After a while all toggled Patches are displayed as unapplied. Two toggle operations seem to be sufficient to trigger this bug (one of them an "apply" action), and when waiting long enough (not very long), it seems that even the last applied Patch becomes unlit.
This behaviour of Patchmanager 2 made me accidentally reappling an already applied Patch at least twice, but doing so does not seem to cause any harm.

*Edit 2:* Now I observed this happening even after applying just a *single* Patch: Waiting a few seconds, the freshly lit button becomes unlit again.

6. Minor usability bug, when returning from detailed Patch information page to list view of installed Patches
Observation:
The specific position of the list view of installed Patches (when returning from a detailed Patch information page) depends on the position of the patch within the list:
a. A position above the word "Homescreen" (indicating the start of this section) or one below it with the word "Homescreen" still visible on the device screen / above the eighth Patch or one with the eighth Patch visible:
The list position is the same as before entering the detailed Patch information page (O.K.).
b. A position so far below the word "Homescreen", that the word "Homescreen" is not visible on the device screen / below the eighth Patch without it being visible:
The list position jumps, so that the first Patch in the section "Homescreen" / the eighth Patch is the topmost displayed one (not O.K.).
(Note that this bug occurs regardless of the device orientation {portrait, landscape}.)
Expected behaviour:
The list position is always the same as before entering a Patch's detailed info page.

7. [Feature suggestion] Display conflicting Patches, when a Patch fails to apply
Background:
Patches conflicting with each other are creating a "conflict hell", which is really hard to resolve manually. E.g. I am currently unable to identify *all* the Patches (out of about 35 installed ones), which conflict with "Ultimate statusbar patch" or "Devicelock faith text". *Edit:* "Force cover size" and "No notification preview" are conflicting with those two Patches!?!
Idea:
It would be extremely helpful for users of Patchmanager2 to be notified specifically, which other Patches (and / or which original file) a Patch conflicts with, when applying it fails.
Thoughts:
Basically all information needed is already there: Which lines in which files each Patch patches (and which original lines a Patch expects). So if Patches intend to patch the same lines, they conflict. If there is no conflict between Patches, but the expected original lines are not present, something else is wrong (most likely the Patch is not compatible with the installed SailfishOS version).

8. [Minor usability bug: Inconsistent wording] "install*" instead of "apply*" and "remove" instead of "unapply" used in notifications
Description:
The wording in Patchmanager2 consistently keeps "installing / uninstalling" and "applying / unapplying" a Patch clearly separate, which is excellent. But in the notifications "install*" instead of "apply*" and "remove" instead of "unapply" is used, which is confusing.
Possible solution:
Please alter the three notifications messages, e.g. as follows.
Note, I also removed the word "Patch" and the action taken repeated in each second line, because the second line is usually way too long for fitting into the transient notification pop-up in the upper left corner of the screen, and the duration the transient notification is displayed is too short for the second line to automatically scroll horizontally (it usually just starts scrolling shortly before the transient notification vanishes).
a. Patch installed : Patch XXX installed
--> Patch applied : "XXX"
b. Failed to install patch : Patch XXX installation failed
--> Failed to apply Patch : "XXX" conflicts with ["YYY" | and "ZZZ" | original file <filename>]
c. When unapplying a Patch:
Patch removed : Patch XXX removed
--> Patch unapplied : "XXX"
d. But when uninstalling a Patch:
Patch removed : Removed patch XXX
--> Patch uninstalled : "XXX"
e. And it seems that:
Failed to remove patch : Patch removal failed
--> Failed to uninstall Patch : "XXX"
Or can Patches also fail to be unapplied (then one has to differentiate, as in c. & d.)?
f. Finally, the remorse timer label currently states
Uninstalling patch XXX in N seconds
which then ought be (just for consistency)
Uninstalling Patch "XXX" in N seconds

HTH & Cheers

P.S.: Continued in ...
Originally Posted by olf View Post
# 2243

Last edited by olf; 2017-06-13 at 00:01. Reason: Edited 5.; Added 6., 7. & 8.; Edited 8.
 

The Following User Says Thank You to olf For This Useful Post: