maemo.org - Talk - View Single Post

josiahg777	2008-06-08 , 17:51
Posts: 425 \| Thanked: 132 times \| Joined on Mar 2008 @ California	#57

Originally Posted by iliaden

I don't really think that this credit is "proper". I didn't write any code myself (since I cannot post it on some site for everyone), so it's not the best idea. you could put me under "ideas contributions". And it would look nicer if you wrote my name, not the nickname: Ilia Denotkine. guess where the nick came from

I still believe It's proper

You've contributed just as much to this as I have

And my apologies for not putting in your full name, I had no way of accessing it or knowing it (The forum doesn't post it, I checked your profile before adding that line) but I'd be more than happy to change this in the next version

code looks good. just for me, to make sure: the file you enter would be with or without the path, and if without, is the default root, user folder or the path where you are?

The path that gets entered here is the same as if you had entered it on the command line and just gets passed to MPlayer in the end so an absolute path or a relative path will work equally well. The only difference is you do NOT have to escape space characters because it gets read as a full string

next, the bitrate is in what, bytes or kilobytes per second?

MPlayer reads video bitrate in bytes per second. Please suggest a better value, I'm absolutely clueless what bitrates to use as delimeters. I was actually following the "standard" bitrates from http://en.wikipedia.org/wiki/Bit_rate
for lack of a better reference :P

and one last comment: the difference between -framedrop and -hardframedrop should be determined by the bitrate and/or fps, not the ORIGINAL resolution.
maybe it's better to write:
Code:
if $FPS -gt 25
    $FRAMEDROP="hardframedrop"
    REST OF THE CODE HERE (the optimizations you wrote, this "if" thus remains independent of the rest"
else 
    $FRAMEDROP="framedrop"
    REST OF THE CODE (or a simple goto would do the trick here in order not to rewrite)
fi
looks good?

Yeah that sounds very reasonable, I'll make sure and change this in the next version... Although having been well disciplined by my CompSci professors I might have an allergic reaction to a "goto" statement

lol I'll see what I can do with it.

With respect to the next version I'm going out of town this afternoon and I won't be home until late Saturday night so I'm probably not going to be able to work on this and I definitely won't be able to upload anything. I'll try and get the next version out by next Sunday afternoon though

Sorry about that.

You're more than free to edit the code however you like, if you'll just email me the edited code I'd be more than happy to tar it up (or you can do it, either way) and host it on my webspace

My email address is josiahgaskin@gmail.com I usually reply to email the same day, same with PMs in this forum.

__________________
Promises are like babies. Fun to make, but hard to deliver.

Warning: dates on calendar are closer than they appear.

Quote & Reply |