Thread
:
[Debian] ANNOUNCE: Easy Debian Turbo-Charged Edition!
View Single Post
pipeline
2009-02-18 , 02:39
Posts: 693 | Thanked: 502 times | Joined on Jul 2007
#
530
I believe i have the latest scripts which i got from your repo.
Hmm, this is tricky from a policy point of view. Ok so your lock flag/file determines whether the fs has been mounted+binds.
I guess i'm looking for the mount operation to be atomic (done by my script) and binds+chroot to be other operation done by ezchroot.
I don't want to be too intrusive so i'll just make a few suggestions/requests to clarify how this might be reworked/reworded. I'm not certain anyone other than myself would benefit so i have no problem manually chrooting using my old way if you dont want to support this level of control....
- Perhaps the lock file could be renamed to something like fixture-setup. Only because this reminds me of nunit/junit tests where you setup and teardown the fixture but in between you run many operations.... but the chroot is not part of the setup, its one of the operations.
- I'm thinking i want to ask if you can add parameterized flags to control mount/binds+performancetweaks/chroot operations independently. Could just be 1 1 1 or for my instance 0 1 1 and perhaps default to 1 1 1 if those params are not passed. Then if those flags are set you would use those instead of the flag file. I suppose the closechroot would have act the same way.
The downside is that the 'flag' is not preserved between invocations, so at that point you would be passing responsibility to the calling script to make sure that subsequent operations (on a single mount) keep the mounted fs in a proper state (avoiding re-symlinking on a single mount or mounting twice).
I could add this logic to my scripts (for my purpose), since I dont support simultaneous chroots on a single mount. I currently 'own' my mountpoints (created as part of deb install) which have a default file ext2mount.txt i can test for to see if mountpoint is 'free/available'.
Since i have backup solution, it might be best to let this sit for awhile until you get a handle on how other people want to use these scripts. But i have gained alot from this and earlier iterations of your chroot scripts so thanks to you and benson for working all this out so that i can use it for the myriad of permutations i intend to bend it to
Last edited by pipeline; 2009-02-18 at
02:42
.
pipeline
View Public Profile
Send a private message to pipeline
Find all posts by pipeline