If you actually want to have it use the editor you want then simply: export EDITOR=vi

Also you can change settings in /etc/fcron.conf I believe to tell it to use a different default editor.

You certainly don't need that mkdir and ln