View Single Post
Nathraiben's Avatar
Posts: 267 | Thanked: 408 times | Joined on May 2010 @ Austria
#13
Originally Posted by pantera1989 View Post
I have the following feedback for you after playing around with the application.

First of all the application did not work. I think it's permissions like you said. Here is the output:

Code:
~ $ python /opt/ApMeFo/Main.py
Traceback (most recent call last):
  File "/opt/ApMeFo/ui/appFolders.py", line 174, in on_btnAddNameSelect_released
    self.mainApp.foldercontent.setFolder(str(filename))
  File "/opt/ApMeFo/classes/folderContent.py", line 35, in setFolder
    menuFile = open(menuFileName,  "r")
IOError: [Errno 2] No such file or directory: PyQt4.QtCore.QString(u'/home/user/.config/menus/submenus/Games.menu')
Traceback (most recent call last):
  File "/opt/ApMeFo/ui/appFolders.py", line 163, in on_btnUpdate_released
    self.mainApp.foldercontent.updateFolder()
  File "/opt/ApMeFo/classes/folderContent.py", line 63, in updateFolder
    includeNode = self.xmlTree.getElementsByTagName("Include")[0]
AttributeError: 'NoneType' object has no attribute 'getElementsByTagName'
Traceback (most recent call last):
  File "/opt/ApMeFo/ui/appFolders.py", line 163, in on_btnUpdate_released
    self.mainApp.foldercontent.updateFolder()
  File "/opt/ApMeFo/classes/folderContent.py", line 63, in updateFolder
    includeNode = self.xmlTree.getElementsByTagName("Include")[0]
AttributeError: 'NoneType' object has no attribute 'getElementsByTagName'
Actually, that doesn't sound like a permission problem, but rather like writing the folder in the first place somehow failed.

Did you get the "Your folder was successfully saved!" message when creating the folder? Or did you try to edit a folder you manually added before installing the application?

Normally, if there's any problem with writing the .menu file, there should be a warning be displayed - I'll take a look at that part, maybe this slipped through while cleaning the code.

Now to feedback regarding the working app.

1. The menu that comes up each time with the apps to add is too slow. Could the content be somehow cached on the app's startup? I doubt that someone will install anything new while the app is running. This way the first time loading will take time, but further tries will be much faster.
2. Could the apps menu let you select multiple items at a time? Like some menus in the browser?
3. The apps menu should be updated. If you select an app it should be removed from the menu.
4. Could there be an option to sort alphabetically once added in the folder?
5. I used the de-activate option. It works but the device become unresponsive, forcing you to restart. Could this process be a bit more fluid?

** EDIT ** While running it from xterm as root, it still couldn't create the folder, but pressing de-activate didn't make the device unresponsive and the menu was restored.
First of all, thanks a lot for those suggestions!

1) I was (and still am) not sure how to handle this. Simply storing the values would be easy, but then the whole application could turn rather unstable thanks to modifications (both internal and external) to the files involved. So I'm swaying between making this faster or keeping it more stable.

2) Great idea, I'll take a look into that - should be fairly easy to implement, though.

3) Do you mean from the popup list? That would be nice, true - though for larger folders this might further slow down the popup. I'll give it a try.

4) In the actual application menu (it already should do that) or in the list on the Add Apps tab? The latter (and maybe in the popup list, too - but again this could turn out to be a performance problem) I'll put right on top of my todo list. I just realised how confusing the non-alphabetic list really is.

5) Sadly, that's something I have no influence on. Hildon is becoming unresponsive because it suddenly "lost" it's hildon.menu (though normally this shouldn't take any longer than a couple of seconds). Catorise is suffering from the same problem, so I fear nobody has found a solution to this yet...

Also, opening the application menu right after making changes (no matter whether it's adding folders or de-/activating ApMeFo) will result in a "No applications found" message at first, but this, also, should go away after a few seconds.

After that I haven't experienced any more slow-downs, so this should only happen right after editing the menu.