Originally Posted by Markkyboy

Hey guys, I wonder if anyone can shed some light on a weird but not so troubling problem.

I've made a patch (RPM), the app installs to patchmanager, but patchmanager can't apply and an error message just says 'failed to install'.

My patch makes some very minor changes in 'compositor.qml' and 'VolumeControl.qml'.
I am able to make my changes manually to the device and they work, even after a reboot.

So, why can I not apply the patch? - now, as the changes work when done manually, I'm going to assume that my spec file is the problem, as I get an error when uninstalling the patch.rpm; something like ("// error: line 2: is a directory) with a message about the %preun section - but the thing is, all my other patches are structured in the same way and they all install/patch/work/unapply/uninstall - but not this one.

Here's the spec contents; (shortened)

Code:

%description
Control the volume with 2 fingers portrait or both thumbs in landscape mode

%files
/usr/share/patchmanager/patches/sailfishos-patch-two-fingers-volume-control/*

%pre
if [ $1 = 1 ]; then
    // Do stuff specific for first install
echo "It's first time install"
else
if [ $1 = 2 ]; then
    // Do stuff specific to upgrades
echo "It's just upgrade"
/usr/sbin/patchmanager -u sailfishos-patch-two-fingers-volume-control
fi
fi

%preun
if [ $1 = 0 ]; then
    // Do stuff specific to uninstalls
/usr/sbin/patchmanager -u sailfishos-patch-two-fingers-volume-control
else
if [ $1 = 1 ]; then
    // Do stuff specific to upgrades
echo "It's just upgrade"
fi
fi

%postun
if [ $1 = 0 ]; then
    // Do stuff specific to uninstalls
rm -rf /usr/share/patchmanager/patches/sailfishos-patch-two-fingers-volume-control
else
if [ $1 = 1 ]; then
    // Do stuff specific to upgrades
echo "It's just upgrade"
fi
fi

%changelog

Any information gratefully received

Regards,

Originally Posted by coderus

if you cant apply patch its 100% problem in patch
spec file is for building and installing package

Originally Posted by Markkyboy

Thanks coderus, you may laugh, but there are no other patches installed. In fact a fresh install of patchmanager after installing lipstick-jolla-home-qt5 DIR again. I appreciate what you are saying and I know you know your stuff. But there are no other patches installed. So, if it is not to do with the spec file, why th error warning about Line 2: in %preun section..??

Also, @schturman - how do I check that I created the patch correctly? - I have altered my unified_diff.patch several times, putting voljmecontrol qml diff first then compositor.qml and vice versa.........if I make the alterations manually, the idea works, but trying to patch it, it fails. Weird.

Originally Posted by coderus

for example you can post your patch here and someone can show where is your fault.
and you should never alter patch file by hand, you should use git or diff tool instead.

Originally Posted by coderus

i see wrong filenames for both blocks and unwanted whitespace line after first block