Active Topics
-
The N900 is now 15 years old! (9)
to Nokia N900 by Arno_11 - 7 hrs, 53 mins ago -
Sailfish OS for the Motorola Moto G7 Power (XT1955-5) - (ocean) (4)
to SailfishOS by Maemish - 5 days, 20 hrs ago - more...
|
2010-06-14
, 20:03
|
|
Posts: 87 |
Thanked: 36 times |
Joined on Sep 2009
@ Helsinki
|
#142
|
First of all, thanks for an excellent 'app'.
I would ask that you consider adding some features:
1) Status display:
I have a lot of large playlists, so logging in takes more than a minute, even on wifi. On 3G it takes usually 2-3 minutes, and some times it just seems to fail log in altogether, even if I wait longer. I suppose that's due to network latency. Some sort of status message à la "Connecting... network failure" or "Connecting... log in successful... updating playlists..." would be very nice. Also, similar messages while waiting for the next song to start to play would help. Right now, there's just no way to know if the application hanged up, or it's just taking time to buffer.
Edit: Enabling cache certainly eases the situation. Still seems to hang up occasionally if 3G reception is poor, though.
As a side note, I notice there was some talk about some songs just not starting to play. This seems to happen a lot with the official client also, so maybe it's not despotify's problem this time?
2) Configurable buffering:
I see that this has already been discussed a lot, but if you decide to implement an audio buffer, I'd like it to be adjustable. Say, "play only after entire song is buffered", or buffer n-percent before starting playback.
3) Menu shortcut to FM-transmitter:
I use this a lot while driving. FM-transmitter works perfectly, but at the moment I need to go via phone settings to enable it. Both the default media player and Mediabox have their own menu shortcuts, which is quite handy. Perhaps you could duplicate this?
All in all, I enjoy using footify a lot. Keep up the good work!
I would ask that you consider adding some features:
1) Status display:
I have a lot of large playlists, so logging in takes more than a minute, even on wifi. On 3G it takes usually 2-3 minutes, and some times it just seems to fail log in altogether, even if I wait longer. I suppose that's due to network latency. Some sort of status message à la "Connecting... network failure" or "Connecting... log in successful... updating playlists..." would be very nice. Also, similar messages while waiting for the next song to start to play would help. Right now, there's just no way to know if the application hanged up, or it's just taking time to buffer.
Edit: Enabling cache certainly eases the situation. Still seems to hang up occasionally if 3G reception is poor, though.
As a side note, I notice there was some talk about some songs just not starting to play. This seems to happen a lot with the official client also, so maybe it's not despotify's problem this time?
2) Configurable buffering:
I see that this has already been discussed a lot, but if you decide to implement an audio buffer, I'd like it to be adjustable. Say, "play only after entire song is buffered", or buffer n-percent before starting playback.
3) Menu shortcut to FM-transmitter:
I use this a lot while driving. FM-transmitter works perfectly, but at the moment I need to go via phone settings to enable it. Both the default media player and Mediabox have their own menu shortcuts, which is quite handy. Perhaps you could duplicate this?
All in all, I enjoy using footify a lot. Keep up the good work!
|
|
2010-06-14
, 20:06
|
|
Posts: 9 |
Thanked: 0 times |
Joined on Jun 2010
|
#143
|
Originally Posted by Joorin
That's unfortunately the only thing I can find so far. Do you have any debug logging which I can enable to help you troubleshoot further?
Just for completeness, could you perhaps supply that output too? I'm looking in the source code for libdespotify and I see no possibility for this error to appear with wrong username/password so now I'm getting really curious. I must have overlooked something.
Wild guesses: Do you have many playlists? Are you logged into Spotify from another client at the same time? Is your premium account very fresh?
I really can't think of any real source for your problem. The trace you supply suggests that it crashes somewhere after login but before populating the list of playlists so I'll look closely there and see if I can find something.
|
|
2010-06-14
, 20:08
|
|
Posts: 9 |
Thanked: 0 times |
Joined on Jun 2010
|
#144
|
Originally Posted by wcborstel
To quote myself: Yes, this is the bug. After adding a playlist I can successfully login and I can play a song from the playlist.
Maybe because I don't have any playlists it's crashing?
|
|
2010-06-14
, 20:18
|
|
Posts: 726 |
Thanked: 345 times |
Joined on Apr 2010
@ Sweden
|
#145
|
Originally Posted by wcborstel
Oh, I actually spent some time looking at exactly this part of the code and it looks as if it will handle this case. I will investigate further.
To quote myself: Yes, this is the bug. After adding a playlist I can successfully login and I can play a song from the playlist.
Thank you for the feedback and help with debugging! This kind of bug is typical of just testing the path through the code where things go as intended, as in "Who'd use the client without playlists? Pff, no-one! I'm sure it works...".
|
|
2010-06-14
, 20:33
|
|
Posts: 726 |
Thanked: 345 times |
Joined on Apr 2010
@ Sweden
|
#146
|
Originally Posted by Suurorca
There are two parts to this: how calls to libdespotify are done and cache handling.
First of all, thanks for an excellent 'app'.
I would ask that you consider adding some features:
1) Status display:
I have a lot of large playlists, so logging in takes more than a minute, even on wifi. On 3G it takes usually 2-3 minutes, and some times it just seems to fail log in altogether, even if I wait longer. I suppose that's due to network latency. Some sort of status message à la "Connecting... network failure" or "Connecting... log in successful... updating playlists..." would be very nice. Also, similar messages while waiting for the next song to start to play would help. Right now, there's just no way to know if the application hanged up, or it's just taking time to buffer.
Edit: Enabling cache certainly eases the situation. Still seems to hang up occasionally if 3G reception is poor, though.
As things are implemented now, calls to libdespotify are done using the same thread that updates the application UI, which is the GTK main thread. Typically, doing things that way is bad, since updates might be delayed if the call takes a while to finish.
To fix this, and I think I mentioned this a few posts back, I need to decouple the call to libdespotify from the GTK main thread and deliver the result in an asynchronous manner. This would increase the complexity of the application a bit so I'm putting this off until the "basic functionality" is stable. So, it's on my TODO list.
Until then, things might seem a bit opaque (not knowing what's going on) but I hope the benefits of getting things more stable first outweighs this.
Secondly, cache handling of playlists is done atomically. Meaning that as long as you don't change anything, in any playlist, the local copy can be used and then even very big playlists shouldn't take more than a couple of hundred milliseconds to load. But, if you change anything, libdespotify will re-download the whole thing.
As a side note, I notice there was some talk about some songs just not starting to play. This seems to happen a lot with the official client also, so maybe it's not despotify's problem this time?
2) Configurable buffering:
I see that this has already been discussed a lot, but if you decide to implement an audio buffer, I'd like it to be adjustable. Say, "play only after entire song is buffered", or buffer n-percent before starting playback.
3) Menu shortcut to FM-transmitter:
I use this a lot while driving. FM-transmitter works perfectly, but at the moment I need to go via phone settings to enable it. Both the default media player and Mediabox have their own menu shortcuts, which is quite handy. Perhaps you could duplicate this?
All in all, I enjoy using footify a lot. Keep up the good work!
Thank you for the feedback and suggestions. I'm glad you like it.
|
|
2010-06-15
, 06:23
|
|
Posts: 726 |
Thanked: 345 times |
Joined on Apr 2010
@ Sweden
|
#147
|
Version 0.0.8-4 has been uploaded to the repositories and the Garage page.
New functionality:
+ Album and artist search now also works for playlists.
Changes:
* Some refactoring of the code.
Please note:
The bug in libdespotify that makes the application crash when searching for an artist after having searched for an album is still not fixed.
New functionality:
+ Album and artist search now also works for playlists.
Changes:
* Some refactoring of the code.
Please note:
The bug in libdespotify that makes the application crash when searching for an artist after having searched for an album is still not fixed.
| The Following 2 Users Say Thank You to Joorin For This Useful Post: | ||
|
|
2010-06-15
, 17:43
|
|
Posts: 9 |
Thanked: 0 times |
Joined on Jun 2010
|
#148
|
Originally Posted by Joorin
And thanks for your support! Glad to have it working now. And you know what they say ... assumption is the mother of all f*ckups
Thank you for the feedback and help with debugging! This kind of bug is typical of just testing the path through the code where things go as intended, as in "Who'd use the client without playlists? Pff, no-one! I'm sure it works...".
Anyway, one other thing I did notice. The 3G network of a specific provider here in the Netherlands is rather poor. Often I find myself with an useless 3G connection. However it seems that footify doesn't always recover from a lack of internet connection when it's playing a song (specifically when the connection is not responding for over a minute or so). Also the entire interface is not responding as soon as the 3G connection drops (it only continues to respond when the connection is re-established). Maybe it's possible to make this non-blocking so footify is actually still usable? At least so you can still properly close the app without Maemo saying that footify is not responding asking for a forced shutdown.
|
|
2010-06-15
, 21:19
|
|
Posts: 726 |
Thanked: 345 times |
Joined on Apr 2010
@ Sweden
|
#149
|
Originally Posted by wcborstel
Indeed.
And thanks for your support! Glad to have it working now. And you know what they say ... assumption is the mother of all f*ckups
Anyway, one other thing I did notice. The 3G network of a specific provider here in the Netherlands is rather poor. Often I find myself with an useless 3G connection. However it seems that footify doesn't always recover from a lack of internet connection when it's playing a song (specifically when the connection is not responding for over a minute or so). Also the entire interface is not responding as soon as the 3G connection drops (it only continues to respond when the connection is re-established). Maybe it's possible to make this non-blocking so footify is actually still usable? At least so you can still properly close the app without Maemo saying that footify is not responding asking for a forced shutdown.
This will, hopefully, not happen when I've decoupled the GUI thread from calls to libdespotify.
So, known issue that's on my TODO list. And pretty close to the top.
|
|
2010-06-17
, 06:26
|
|
Posts: 9 |
Thanked: 0 times |
Joined on Jun 2010
|
#150
|
Ah right, makes sense now. Thanks.
Just one more thing while I'n at it (may as well tell you everything eh?), when I have selected a playlist there is no (obvious) way to go back and select another playlist. maybe I have missed that button somewhere but I can't find any way to do that.
All in all I am really pleased with it so far, thanks very much for your hard work on it!
Just one more thing while I'n at it (may as well tell you everything eh?), when I have selected a playlist there is no (obvious) way to go back and select another playlist. maybe I have missed that button somewhere but I can't find any way to do that.
All in all I am really pleased with it so far, thanks very much for your hard work on it!
Wild guesses: Do you have many playlists? Are you logged into Spotify from another client at the same time? Is your premium account very fresh?
I really can't think of any real source for your problem. The trace you supply suggests that it crashes somewhere after login but before populating the list of playlists so I'll look closely there and see if I can find something.