Notices

If the user is not logged in, the token will be an empty string

Originally Posted by ruff

BTW it was the same on pebbled, the implementation in jskitobjects.cpp is identical,

Originally Posted by ruff

yeah, i think this is it, see https://developer.pebble.com/guides/...#account-token

Since we don't give users ability to login - the accounToken is always empty, and the current implementation is faking it:

Code:

    // We do not have any account system, so we just fake something up.
...
    if (token.isEmpty()) {
        token = QUuid::createUuid().toString();

It means all apps relying on account token won't work till we fix that. It also means that current implementation guarantees anonymity %)
unfortunately my mitmproxy dump from android has been done with already logged in account, so I don't have that exchange captured. Need to re-iterate the process.
BTW it was the same on pebbled, the implementation in jskitobjects.cpp is identical,

Originally Posted by abranson

From a libpebble standpoint the code would probably be identical in RockWork and RockPool, but what about the appstore client?

Originally Posted by ruff

We're also reusing native code implementation from rockwork mostly, of course we have own platfrom layer in main.cpp but the rest is mostly as-is. We can rename main.cpp to rockpool.cpp to avoid conflicts and then keep rest of the code shared.
Our QML part is also independent now since we've moved it to sailfish-specific dirs (pages/covers).
It's a pity we don't have track log for bazaar - so we cannot say what actually changed since initial import. And unfortunately during the initial import you didn't preserve original state so we also don't have a track of how far we deviated from them during the import.
From what I can see we have only servicecontrol.cpp, pebble.cpp and main.cpp (of course) changed since initial import.
These are topics to settle down if we targeting the merge though.

Originally Posted by ruff

Oh, excellent, so you should be in a better position to say what has changed
We can probably merge pebble and servicecontrol files, just need to move service name definition to some external file, bcz changes there are mostly fixes (missing calls).
We could even make libpebbleclient.so lib and strip down platform part to mere initialization.

Originally Posted by ruff

But QMLs are out of the scope, they are all different and platform specific, you can return original qml files from bazaar if bzr is complaining - original were in the client's root folder(rockwork).