Notices


Reply
Thread Tools
Posts: 3,617 | Thanked: 2,412 times | Joined on Nov 2009 @ Cambridge, UK
#281
Version 0.12.10-16 now uploaded for both Fremantle and Diablo. The changes are:
  • Fixed direction for drag-scrolling in the library view
  • Fixes to variable initialisation, cleanup, etc. as reported by valgrind
  • Fix to support editable combo boxes (author, series, etc)
  • Removed threading - this had been bolted to support the Maemo banners and progress spinner, but without ensuring thread-safe behaviour, causing lockups, errors and segfaults
  • Check window is still displayed before attempting to display banner or busy spinner
  • Added option allowing enabling/disabling of library scroll bar
  • Added Quit option to the popup menu

The source code changes are available from here.

The removal of threading means that long-running processes (version migration, library load, book load) sometimes fail to show the busy message (the banner/box shows but there's no text) and the busy spinner is static for Diablo (for Fremantle this still works though - must be handled outside the application). Unfortunately I don't see any other way around this - the application doesn't have any support for multi-threading, and fitting it in properly afterwards means a near-total rewrite.
 

The Following 9 Users Say Thank You to Rob1n For This Useful Post:
Posts: 5,795 | Thanked: 3,151 times | Joined on Feb 2007 @ Agoura Hills Calif
#282
I have a problem of long standing with my beloved FBReader, which I always keep updated to the newest available version.

When I want to change to another program that is running -- any other program, such as a browser -- and I hit the icon with the two overlapping squares at the upper left corner of the screen, my FBReader almost always starts scrolling so that I am no longer on the page where I was last reading my book.

If I change to another program by hitting Ctrl-BkSp or by depressing the camera key, this scrolling never happens.
__________________
All I want is 40 acres, a mule, and Xterm.
 
Posts: 3,617 | Thanked: 2,412 times | Joined on Nov 2009 @ Cambridge, UK
#283
Originally Posted by geneven View Post
I have a problem of long standing with my beloved FBReader, which I always keep updated to the newest available version.

When I want to change to another program that is running -- any other program, such as a browser -- and I hit the icon with the two overlapping squares at the upper left corner of the screen, my FBReader almost always starts scrolling so that I am no longer on the page where I was last reading my book.

If I change to another program by hitting Ctrl-BkSp or by depressing the camera key, this scrolling never happens.
That's an odd one - what scrolling options do you have enabled in FBReader?
 
Posts: 5,795 | Thanked: 3,151 times | Joined on Feb 2007 @ Agoura Hills Calif
#284
Originally Posted by Rob1n View Post
That's an odd one - what scrolling options do you have enabled in FBReader?
Enable scrollbar.

Defaults for the rest, I think:

Lines to scroll per line scrolling 1
Lines to keep per page scrolling 1
Delay between key scrollings, msecs 101
Enable tap scrolling is not checked.

Enable text Selection is checked, fwiw, and when the scrolling described is happening, text selection is happening.

BTW: I thought maybe my finger was brushing the screen and somehow causing the scrolling, but when I poked the overlapping rectangles right in the center with a stylus, the scrolling still happened.
__________________
All I want is 40 acres, a mule, and Xterm.
 
Posts: 3,617 | Thanked: 2,412 times | Joined on Nov 2009 @ Cambridge, UK
#285
Originally Posted by geneven View Post
Enable text Selection is checked, fwiw, and when the scrolling described is happening, text selection is happening.
Looks to be related to the text selection - I'll dig into the code and see what it's doing there.
 
Posts: 5,795 | Thanked: 3,151 times | Joined on Feb 2007 @ Agoura Hills Calif
#286
Confirmed -- when I turn off text selection, the problem goes away.

Edit: If you have text selection turned on and click one word in the text to highlight it and then click the title of the book (above the text), note that the highlighlit area expands beyond the one word. This might be the same problem.
__________________
All I want is 40 acres, a mule, and Xterm.

Last edited by geneven; 2010-11-17 at 10:16.
 
Posts: 3,617 | Thanked: 2,412 times | Joined on Nov 2009 @ Cambridge, UK
#287
Originally Posted by geneven View Post
Confirmed -- when I turn off text selection, the problem goes away.

Edit: If you have text selection turned on and click one word in the text to highlight it and then click the title of the book (above the text), note that the highlighlit area expands beyond the one word. This might be the same problem.
Yes, probably. I think we're receiving a movement event as the "cursor" is moving out of the application. I'm going to try adding a check for this - hopefully the reported position can be matched as being outside the window, in which case I can just skip processing the event. Another possibility is trying to track press & release events and stop processing movement events which aren't actual drags (currently every pair of taps seems to be interpreted as a movement event).
 
Posts: 1,418 | Thanked: 1,541 times | Joined on Feb 2008
#288
The Library view has trouble distinguishing between scroll-by-finger-drag and selection. The old FBReader (0.10.*) did not have this problem, as far as I remember.
 
Posts: 838 | Thanked: 292 times | Joined on Apr 2010
#289
Not really do with fbreader, but I thought I would just send out a message to anyone wanting another small reading device...I got the sony prs-350 5 inch ereader and it totally fails in reading the toc on the oreilly books I use. So isn't it funny that a top of the line ereader designed for epub can't even do what a volunteer developer has done on his spare time with fbreader? Just make me appreciate my n900 and this community even more...
 
Posts: 838 | Thanked: 292 times | Joined on Apr 2010
#290
ok that is the second update today.

I'm glad to see we are getting back to a more realistic release schedule
 
Reply


 
Forum Jump


All times are GMT. The time now is 21:36.