Active Topics
-
The N900 is now 15 years old! (9)
to Nokia N900 by Arno_11 - 5 hrs, 44 mins ago -
Sailfish OS for the Motorola Moto G7 Power (XT1955-5) - (ocean) (4)
to SailfishOS by Maemish - 5 days, 18 hrs ago - more...
|
2010-11-29
, 19:21
|
|
Posts: 1,418 |
Thanked: 1,541 times |
Joined on Feb 2008
|
#362
|
Hello, Rob1n
It looks like your latest updated royally screwed up .epub reading, and some other formats too, most likely. Most of the time, the latest FBReader just shows empty screen. Page display also appears to be broken: it only changes after 2-4 page flips in a row.
Whatever you have done to that code broke it. Please, consider rolling back =)
It looks like your latest updated royally screwed up .epub reading, and some other formats too, most likely. Most of the time, the latest FBReader just shows empty screen. Page display also appears to be broken: it only changes after 2-4 page flips in a row.
Whatever you have done to that code broke it. Please, consider rolling back =)
| The Following User Says Thank You to fms For This Useful Post: | ||
|
|
2010-11-29
, 20:12
|
|
Posts: 561 |
Thanked: 75 times |
Joined on Jan 2010
@ Spain
|
#363
|
Excellent application.
Vote for the addition of the ability to create bookmarks, notes, and to copy when full screen without leaving it with the keyboard closed...
Vote for the addition of the ability to create bookmarks, notes, and to copy when full screen without leaving it with the keyboard closed...
|
|
2010-11-29
, 20:24
|
|
Posts: 3,617 |
Thanked: 2,412 times |
Joined on Nov 2009
@ Cambridge, UK
|
#364
|
Originally Posted by fms
I'll have a look into this - the few books I tested worked perfectly, but I've now found one that exhibits the same issues you've reported. I'll see why they're getting the incorrect settings and upload a fixed version shortly.
Hello, Rob1n
It looks like your latest updated royally screwed up .epub reading, and some other formats too, most likely. Most of the time, the latest FBReader just shows empty screen. Page display also appears to be broken: it only changes after 2-4 page flips in a row.
Whatever you have done to that code broke it. Please, consider rolling back =)
|
|
2010-11-29
, 20:34
|
|
Posts: 27 |
Thanked: 10 times |
Joined on Jul 2010
|
#365
|
Originally Posted by Rob1n
I'm ... speechless. Ok. Will you add an upstreams bug, or shall I?
I've tracked down the issue. FBReader uses the margin & padding settings for the same variable, so your zero padding values are overriding the margin values. Removing the padding values from the CSS fixes this issue. I'll have a dig into this further - adding the values would probably be a better solution, but means dealing with unit conversion.
Thanks for looking into this, tho. Atleast I've got a workaround until the ... problem can be fixed.
|
|
2010-11-29
, 20:57
|
|
Posts: 3,617 |
Thanked: 2,412 times |
Joined on Nov 2009
@ Cambridge, UK
|
#366
|
Originally Posted by Rob1n
Okay, 0.12.10-25 uploaded which fixes this (it was failing to check the values had actually been set before using them, so was picking up invalid values).
I'll have a look into this - the few books I tested worked perfectly, but I've now found one that exhibits the same issues you've reported. I'll see why they're getting the incorrect settings and upload a fixed version shortly.
Originally Posted by TinaHolmboe
I'll add the bug at some point - I'm planning on adding bugs/feature requests for all the work I've done.
I'm ... speechless. Ok. Will you add an upstreams bug, or shall I?
Thanks for looking into this, tho. Atleast I've got a workaround until the ... problem can be fixed.
I've fixed this in the latest uploaded version though (0.12.10-25) though, so there should be no need for a workaround. It should be available in the repository shortly.
|
|
2010-11-30
, 05:02
|
|
Posts: 123 |
Thanked: 99 times |
Joined on Sep 2010
@ Russia
|
#367
|
I have a FR: something like checking/filtering read books in library.
And maybe some list of read books, with date, comments, etc.
And maybe some list of read books, with date, comments, etc.
|
|
2010-11-30
, 05:13
|
|
Posts: 422 |
Thanked: 244 times |
Joined on Feb 2008
|
#368
|
Originally Posted by Rob1n
So "always use my css" doesn't apply to font-size? That is disappointing, as the epub font size must presume a DPI. The epub book I have, the font is too small, so I can increase it in base, but then I have to go and decrease it for those books that respect the font size setting in other books.
I'm not sure that's a bug - I think that's all it's intended to do.
__________________
Servwise Advanced Hosting - Better, Faster, Smarter
Hum Consulting - IT and Marketing services to sing about
Servwise Advanced Hosting - Better, Faster, Smarter
Hum Consulting - IT and Marketing services to sing about
 |
|
2010-11-30
, 06:33
|
|
Posts: 800 |
Thanked: 957 times |
Joined on Sep 2010
@ India
|
#369
|
Hey, I just downloaded FBreader after a long time due to all this activity in this thread. And I must say, I am impressed. I expect that FBReader will soon be one amoung my top used apps with Comix, gPodder and www2sms. But a few gripes (bugs?):
The fact that direct dictionary search is included is brilliant. But when text selection is activated, the swiping to turn pages does not work. They only select the text. So could it be possible to have small next/previous page buttons like in Comix?
Once again thanks.
The fact that direct dictionary search is included is brilliant. But when text selection is activated, the swiping to turn pages does not work. They only select the text. So could it be possible to have small next/previous page buttons like in Comix?
Once again thanks.
|
|
2010-11-30
, 09:09
|
|
Posts: 3,617 |
Thanked: 2,412 times |
Joined on Nov 2009
@ Cambridge, UK
|
#370
|
Originally Posted by ForeverYoung
I'll have a look, but I think the latter part will mean database changes, making it incompatible with the upstream version, which I'd rather not do. You could use the tags to flag read books though, and there's some code done for filtering (though it doesn't look to have been completed yet) which I may be able to do something with. That should allow you to check & filter read books.
I have a FR: something like checking/filtering read books in library.
And maybe some list of read books, with date, comments, etc.
Originally Posted by paulkoan
Well, the option is "Always use my font" which I think just overrides the font-family. I'll have a look though - it ought to be possible to override the font size as well.
So "always use my css" doesn't apply to font-size? That is disappointing, as the epub font size must presume a DPI. The epub book I have, the font is too small, so I can increase it in base, but then I have to go and decrease it for those books that respect the font size setting in other books.
Originally Posted by ejasmudar
There's no reason these couldn't go on the toolbar, but that'll have to wait until I've finished writing the menu/toolbar customisation app. In the meantine, you can use the volume buttons to change pages, or enable the "single tap" option for dictionary search (though you then need to be careful of where your swipe starts, as I think the search is triggered on press rather than on release).
Hey, I just downloaded FBreader after a long time due to all this activity in this thread. And I must say, I am impressed. I expect that FBReader will soon be one amoung my top used apps with Comix, gPodder and www2sms. But a few gripes (bugs?):
The fact that direct dictionary search is included is brilliant. But when text selection is activated, the swiping to turn pages does not work. They only select the text. So could it be possible to have small next/previous page buttons like in Comix?
Once again thanks.
| The Following User Says Thank You to Rob1n For This Useful Post: | ||
The source code changes can be downloaded from here.
I'll look to push this to extras-testing at the end of the week, so please let me know if you find any issues before then.