Notices


Reply
Thread Tools
Helmuth's Avatar
Posts: 1,259 | Thanked: 1,341 times | Joined on Oct 2009 @ Germany
#481
Originally Posted by xerxes2 View Post
It seems that Qt doesn't assume utf8 encoding as GTK does so I had to throw in a few encode/decode so the problem should be fixed now.
Don't forget that german is not the only problem. Think about french, greek, russian and all the arabian and chinese, japanese and hindi stuff.

We should try to ensure that it will work in every language without big problems. As far as I know QString was for this. I don't know why this shouldn't work at PySide.
 

The Following User Says Thank You to Helmuth For This Useful Post:
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#482
Originally Posted by Helmuth View Post
Thanks, I haven't created a screenshot now. But what about adding a store button on the right, not inside the scrollarea?

At the moment the scroll area has only 50% screen width, it is centered to the left and the right area is empty.

And at maemo, the cancel behavior is always to click on the empty screen area outside the dialog. So no need for a button. You shoudn't store changes to the settings if someone cancels the dialog.
Hmm, I think you've mentioned this before and thp also made a comment about it in the code. if I understand correctly I think this commit does what you want.
https://github.com/xerxes2/panucci/c...20dee99029a2bd

If it doesn't work or look as expected just tell me and I'll try to fix it. I guess only a save button is needed if you could close the dialog by tap outside it.

Originally Posted by Helmuth View Post
Hmm... At this podcast are several files with umlauts:
http://www1.swr.de/podcast/xml/swr2/impuls.xml

I've read at this forum very often about encoding problems at Qt applications. Using QString instead of String fixed the problems, as far as I know, always. Have a look at the screenshot, the Button in the lower right. In the GTK version the caption is correct shown.
I've tried few podcasts there and they work perfectly now. My german is not that good but the umlauts worked atleast. And I also fixed all widgets to show utf8 strings.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).
 

The Following User Says Thank You to xerxes2 For This Useful Post:
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#483
Originally Posted by Helmuth View Post
Don't forget that german is not the only problem. Think about french, greek, russian and all the arabian and chinese, japanese and hindi stuff.

We should try to ensure that it will work in every language without big problems. As far as I know QString was for this. I don't know why this shouldn't work at PySide.
Thankfully utf8 is a multi byte encoding and supports all of unicode so there's no need for anything else. I've hardcoded utf8 in panucci qt now so it'll only work on systems that use utf8. Linux usually does since many years so it will only be a problem on mac and win. it's not a priority for me to support amc and win anyway, atleast not right now. I guess you could detect the current locale and use that instead of hardcode it to utf8.

And about qstring, I think it's removed because qt will work better with python3. So the locale stuff might work automatically then. I'm still mainly running python 2.6 on this box so I haven't tested it yet. I have python3.2 installed but I havent installed pyside for it. I wonder what python version Harmattan will have? Anyway, N900 is the main target right now for panucci so better make it work properly there first before worrying about coming devices.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).
 

The Following User Says Thank You to xerxes2 For This Useful Post:
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#484
I've located the problem with gpodder now. After going through a few thousands of lines in gpodder i found out that the problem was with panucci's dbus code. I've made small fix now but as I've never used the old panucci and have forgot what was discussed previously in the thread about this stuff you better remind me if it still doesn't work as expected.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).
 

The Following User Says Thank You to xerxes2 For This Useful Post:
Helmuth's Avatar
Posts: 1,259 | Thanked: 1,341 times | Joined on Oct 2009 @ Germany
#485
Originally Posted by xerxes2 View Post
I've located the problem with gpodder now. After going through a few thousands of lines in gpodder i found out that the problem was with panucci's dbus code. I've made small fix now but as I've never used the old panucci and have forgot what was discussed previously in the thread about this stuff you better remind me if it still doesn't work as expected.
WORKS!

I tested it with the gtk version. As far as I can see it works without problems.
At the qt version I was only able to test what happens if panucci is already running. But no problems so far and it shares the dbus code. So it should work.

Perhaps, if a track was opened before we should add a bookmark at the last playback position to the playlist. But this is only luxury.
 

The Following User Says Thank You to Helmuth For This Useful Post:
Helmuth's Avatar
Posts: 1,259 | Thanked: 1,341 times | Joined on Oct 2009 @ Germany
#486
Originally Posted by xerxes2 View Post
Hmm, I think you've mentioned this before and thp also made a comment about it in the code. if I understand correctly I think this commit does what you want.
https://github.com/xerxes2/panucci/c...20dee99029a2bd
WORKS!


Originally Posted by xerxes2 View Post
If it doesn't work or look as expected just tell me and I'll try to fix it. I guess only a save button is needed if you could close the dialog by tap outside it.
Yes, the cancel signal is automatically emitted. (at the Qt UI at least)

I have a request regarding the playlist layout. Perhaps you could change the window height to about 400 or 380pixel?

Originally Posted by xerxes2 View Post
I've tried few podcasts there and they work perfectly now. My german is not that good but the umlauts worked atleast. And I also fixed all widgets to show utf8 strings.
Thats great.
As far as I can see it works now here, too.

Perhaps we should look later at the ui translation. At the Qt version more buttons are not transtated than at the GTK version. But this has no priority.
 

The Following User Says Thank You to Helmuth For This Useful Post:
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#487
Originally Posted by Helmuth View Post
WORKS!

I tested it with the gtk version. As far as I can see it works without problems.
At the qt version I was only able to test what happens if panucci is already running. But no problems so far and it shares the dbus code. So it should work.

Perhaps, if a track was opened before we should add a bookmark at the last playback position to the playlist. But this is only luxury.
You can make panucci use Qt by default by setting "gui=qt" in panucci.conf. But as you say it should work.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).
 

The Following User Says Thank You to xerxes2 For This Useful Post:
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#488
Originally Posted by Helmuth View Post
I have a request regarding the playlist layout. Perhaps you could change the window height to about 400 or 380pixel?
Why? Isn't the window "maximized" already? Perhaps the "Dialog" flag didn't work that well after all? GTK works right? Try the window attribute thp talked about earlier.

Code:
self.main_window.setAttribute(QtCore.Qt.WA_Maemo5StackedWindow )
Put that on line 46 in qtplaylist.py. And take away the Dialog flag from this commit:
https://github.com/xerxes2/panucci/c...357b541ce8c044

Originally Posted by Helmuth View Post
Thats great.
As far as I can see it works now here, too.

Perhaps we should look later at the ui translation. At the Qt version more buttons are not transtated than at the GTK version. But this has no priority.
Yes all strings must be finalized before 1.0. And the reason why some buttons are translated in gtk but not on qt is because they're gtk stock buttons and using system wide translation for gtk. I haven't figured out yet how qt handles stock stuff. My box seems to be half borked too because when I switched to using a gtk theme in qt the stock icons disappeared. Anyway, I'm happy that most stuff works now.

Edit: It's of course qtplaylist.py.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).

Last edited by xerxes2; 2011-03-25 at 12:43.
 

The Following User Says Thank You to xerxes2 For This Useful Post:
Helmuth's Avatar
Posts: 1,259 | Thanked: 1,341 times | Joined on Oct 2009 @ Germany
#489
Originally Posted by xerxes2 View Post
You can make panucci use Qt by default by setting "gui=qt" in panucci.conf. But as you say it should work.
Okay. I have to go to bed now, but as far as I able to test there is still a small bug. Perhaps only at the qt code. I must test this more... but to track my observation:
You're playing a podcast, you stop the playback and close panucci and open the same file using gpodder the playback doesn't start automatically.
If you open a different file the playback starts... hmm...

If you can't reproduce this behavior I will digg more into it tomorrow. (I hope so, no time this weekend as far as I'm able to see from here)


Edit:
Have a look here, because of this I thought a bigger screen height would be a good idea.


It doesn't make for me a big difference if dialog or normal window. Mmmh... expect there is no menu possible. I hope I have tomorrow some time to edit this file on my device and play a little bit with it. Will report how it works...

Last edited by Helmuth; 2011-03-24 at 23:00.
 
xerxes2's Avatar
Posts: 513 | Thanked: 651 times | Joined on Feb 2011 @ Sweden
#490
Originally Posted by Helmuth View Post
Okay. I have to go to bed now, but as far as I able to test there is still a small bug. Perhaps only at the qt code. I must test this more... but to track my observation:
You're playing a podcast, you stop the playback and close panucci and open the same file using gpodder the playback doesn't start automatically.
If you open a different file the playback starts... hmm...
Should be fixed now.

Originally Posted by Helmuth View Post
Have a look here, because of this I thought a bigger screen height would be a good idea.


It doesn't make for me a big difference if dialog or normal window. Mmmh... expect there is no menu possible. I hope I have tomorrow some time to edit this file on my device and play a little bit with it. Will report how it works...
Take a look at this commit:
https://github.com/xerxes2/panucci/c...c595afe2c93f66

If that doesn't work we have to try something else. Does the playlist window work well on gtk? I'd rather avoid setting a fixed size on the playlist window if possible.
__________________
But the WM7 "horse" has a blood lineage tracing back to donkeys such as WM6.5, 6.1, 6.0, 5.1 that was fully neglected for too many years and Microsoft did sweet F all to maintain it (still running on Pocket IE4/6!!).
 
Reply

Tags
barbiestrsand


 
Forum Jump


All times are GMT. The time now is 10:05.