|
2012-12-17
, 23:23
|
Posts: 246 |
Thanked: 2,574 times |
Joined on Jan 2010
@ Egypt, Cairo
|
#8322
|
I know, most people here think, it's the comments by testers, that are the reason, but my understanding of what i read is different.
https://github.com/tgalal/wazapp/pul...mment-11217087
Oh.
It's plain old rejection? tgalal doesn't want to dance with coderus?
if above is the case then i will use nightly8 build always till i have N9 and using whatsapp services.
the above mentioned change was requested by users (us), and coderus did that for us so whats wrong in it. On the other hand its very useful.
you are in group chat and surfing web as well. You can see all incoming msgs in notification area and just go to wazapp when any msg is directed at you or you would like to revert to.any msg until then carry on with whatever you are doing. It could b anything on mobile like watching video, surfing internet, etc
coderus urs nightly 8 is the best build i had on N9. Thanks mate.
cheers
The Following 26 Users Say Thank You to tgalal For This Useful Post: | ||
|
2012-12-18
, 04:09
|
Posts: 152 |
Thanked: 70 times |
Joined on Aug 2012
@ India
|
#8323
|
I personally tried that change and found it buggy, and annoying. I'm sure many users would agree. I'd only add it if it's optional.
.
|
2012-12-18
, 10:28
|
Posts: 40 |
Thanked: 34 times |
Joined on Oct 2012
@ Germany
|
#8324
|
The Following User Says Thank You to d@niel For This Useful Post: | ||
|
2012-12-18
, 14:40
|
Posts: 5 |
Thanked: 0 times |
Joined on May 2012
|
#8325
|
|
2012-12-18
, 19:59
|
Posts: 239 |
Thanked: 70 times |
Joined on Oct 2010
@ Germany
|
#8326
|
I don't see how this could be related
Rejecting a single change from the many ones coderus kindly contributes doesn't mean it's the end.
I personally tried that change and found it buggy, and annoying. I'm sure many users would agree. I'd only add it if it's optional.
I would like also to clear out that I do believe Wazapp without efforts from guys like Cepi, Coderus, Knobtviker and other contributors wouldn't have made it to the state it has become today. No one asked me to create that credits page, and they are included there for a reason despite any disagreements I might have had with any of them (Coderus should jump to major contributors btw, his contributions are invaluable). Last I heard, disagreements between devs is a normal thing.
What's also normal is that I should not blindly accept whatever I get. I try to carefully inspect and test the changes I receive. If I reject some change, then it must be for a reason which has to do with the quality of the app; either externally for users, or internally for other devs. This however rarely happens as most of the time I either try to fix issues that I find in a pull request myself, or ask the submitter to change it.
I admit I do get mad sometimes and perhaps I act offensive, actually wazapp's code is full of could-be-offensive comments written by me. However, if a developer can't take criticism about his own "public" code, then perhaps he should go find something else to do.
The Following User Says Thank You to snooky For This Useful Post: | ||
|
2012-12-18
, 23:10
|
Posts: 3 |
Thanked: 0 times |
Joined on Dec 2012
|
#8327
|
|
2012-12-18
, 23:12
|
Posts: 246 |
Thanked: 2,574 times |
Joined on Jan 2010
@ Egypt, Cairo
|
#8328
|
The Following 5 Users Say Thank You to tgalal For This Useful Post: | ||
|
2012-12-18
, 23:21
|
Posts: 3 |
Thanked: 0 times |
Joined on Dec 2012
|
#8329
|
|
2012-12-19
, 08:06
|
Posts: 1 |
Thanked: 0 times |
Joined on Dec 2012
|
#8330
|
Tags |
godoftool, harmattan, is-a-miracle, nokia n9, spacker_thread, tarekgalal, toddler_daycare, toolcoderus, wazapp, whatsapp |
|
Telegram | Openrepos | GitHub | Revolut donations