Page 2 of 2 1 2
Reply
Thread Tools
shubell is offline shubell
2016-11-17 , 10:27
Posts: 64 | Thanked: 84 times | Joined on Oct 2012
#11
I've got one silly question. Where is the fmms source code repository? Or do you just edit the onphone python files?
 

The Following 2 Users Say Thank You to shubell For This Useful Post:
pichlo's Avatar
pichlo is offline pichlo
2016-11-17 , 11:12
Posts: 6,447 | Thanked: 20,981 times | Joined on Sep 2012 @ UK
#12
Originally Posted by shubell View Post
I've got one silly question. Where is the fmms source code repository?
Have you checked the package page?

Or do you just edit the onphone python files?
Or
__________________
Русский военный корабль, иди нахуй!
 

The Following 4 Users Say Thank You to pichlo For This Useful Post:
peterleinchen's Avatar
peterleinchen is offline peterleinchen
2016-11-17 , 20:45
Posts: 4,118 | Thanked: 8,901 times | Joined on Aug 2010 @ Ruhrgebiet, Germany
#13
Some more links (courtesy of Ilew):

Package page at:
http://maemo.org/packages/view/fmms/

frals' original fmms (missing last/my changes but has the non-binary translation files):
https://github.com/frals/fmms

frals' project (1.3.4 is the latest):
https://garage.maemo.org/projects/fmms/

Some new decoding fmms patch:
https://bugs.maemo.org/show_bug.cgi?id=12733

Some python messaging mms with seems to be based on fMMS mms code:
https://github.com/pmarti/python-mes.../messaging/mms


I myself just used the 'OR'!
So latest/current code can be found here:
http://maemo.org/packages/source/vie.../fmms/1.3.6-1/
__________________
SIM-Switcher, automated SIM switching with a Double (Dual) SIM adapter
--
Thank you all for voting me into the Community Council 2014-2016!

Please consider your membership / supporting Maemo e.V. and help to spread this by following/copying this link to your TMO signature:
[MC eV] Maemo Community eV membership application, http://talk.maemo.org/showthread.php?t=94257

editsignature, http://talk.maemo.org/profile.php?do=editsignature
 

The Following 3 Users Say Thank You to peterleinchen For This Useful Post:
Ilew is offline Ilew
2016-11-18 , 08:13
Posts: 75 | Thanked: 269 times | Joined on Aug 2012
#14
I just grabbed the source from peterleinchen's last link.
However it is missing the source translation files.

I have pending maintainership for fMMS, so I should be able to push my fixes soon.

edit: I do my changes/small tests on my computer first then copy over the files to my phone when I'm ready to test actually sending MMSs.
 

The Following 3 Users Say Thank You to Ilew For This Useful Post:
xes is offline xes
2016-11-18 , 13:02
Posts: 638 | Thanked: 1,692 times | Joined on Aug 2009
#15
Pending request approved.
 

The Following 4 Users Say Thank You to xes For This Useful Post:
shubell is offline shubell
2016-12-16 , 06:54
Posts: 64 | Thanked: 84 times | Joined on Oct 2012
#16
well i did a fork on github and merged all the changes. I also included the decoding patch in.
 

The Following 3 Users Say Thank You to shubell For This Useful Post:
Ilew is offline Ilew
2016-12-17 , 20:40
Posts: 75 | Thanked: 269 times | Joined on Aug 2012
#17
Originally Posted by shubell View Post
well i did a fork on github and merged all the changes. I also included the decoding patch in.
Very nice, you beat me to it.
I was making my own fMMS git and push some new PEP8 changes (I also dislike TABs). (I really should do that soon.)

With the patches that you've applied, do you have anyway to test that they work?
 

The Following 2 Users Say Thank You to Ilew For This Useful Post:
shubell is offline shubell
2016-12-19 , 18:08
Posts: 64 | Thanked: 84 times | Joined on Oct 2012
#18
well the mms decofing patches are from here
https://bugs.maemo.org/show_bug.cgi?id=12733

things should work but did not test them. Even if they don't the basic functionality does not change as it only adds some new ones
 

The Following 3 Users Say Thank You to shubell For This Useful Post:
Ilew is offline Ilew
2016-12-19 , 22:17
Posts: 75 | Thanked: 269 times | Joined on Aug 2012
#19
Originally Posted by shubell View Post
well the mms decofing patches are from here
https://bugs.maemo.org/show_bug.cgi?id=12733

things should work but did not test them. Even if they don't the basic functionality does not change as it only adds some new ones
Well having a quick look at it, there's a possible problem with the changes to decodeWellKnownCharset method.
(Besides the original problem with the 'decodcedCharSet' typo. Though that may/may not be an actual problem)

Hopefully I got this correct as it's a bit tricky.

Encoded-String-Value can be sent as either 'Text-string or Value-length, Char-set, Text-string'

So if it's octet 127 instead of 128, then we aren't using a charset and we should be using either '*' or ''.
See :
Code:
The special value "*", if present in the Accept-Charset field, matches every character set (including ISO-8859-1) which is not mentioned elsewhere in the Accept-Charset field. If no "*" is present in an Accept-Charset field, then all character sets not explicitly mentioned get a quality value of 0, except for ISO-8859-1, which gets a quality value of 1 if not explicitly mentioned.

If no Accept-Charset header is present, the default is that any character set is acceptable. If an Accept-Charset header is present, and if the server cannot send a response which is acceptable according to the Accept-Charset header, then the server SHOULD send an error response with the 406 (not acceptable) status code, though the sending of an unacceptable response is also allowed.
The patch above is matching with all charsets if one is given and trying to match a specific charset when none is given.
Which doesn't make sense.

Hopefully someone can chime in if I got anything wrong.
 

The Following 3 Users Say Thank You to Ilew For This Useful Post:
peterleinchen's Avatar
peterleinchen is offline peterleinchen
2016-12-19 , 22:25
Posts: 4,118 | Thanked: 8,901 times | Joined on Aug 2010 @ Ruhrgebiet, Germany
#20
Originally Posted by Ilew View Post
...
Hopefully I got this correct as it's a bit tricky.

...

The patch above is matching with all charsets if one is given and trying to match a specific charset when none is given.
Which doesn't make sense.

Hopefully someone can chime in if I got anything wrong.
And that was the reason why I did not included/used this patch. I also did not get it completely and must say (to my shame) that I understand even less today what it really should patch ...
__________________
SIM-Switcher, automated SIM switching with a Double (Dual) SIM adapter
--
Thank you all for voting me into the Community Council 2014-2016!

Please consider your membership / supporting Maemo e.V. and help to spread this by following/copying this link to your TMO signature:
[MC eV] Maemo Community eV membership application, http://talk.maemo.org/showthread.php?t=94257

editsignature, http://talk.maemo.org/profile.php?do=editsignature
 

The Following User Says Thank You to peterleinchen For This Useful Post:
Reply
Page 2 of 2 1 2

« Previous Thread | Next Thread »

 
Forum Jump


All times are GMT. The time now is 21:15.

Contact Us - Home - Archive - Top